Skip to content

Conversation

@imba-tjd
Copy link
Contributor

@imba-tjd imba-tjd commented Nov 18, 2018

Summary:

  • Add dev_langs to metadata
  • Move snippets to file

Questions:

  1. These files contain quotation mark in metadata while some others not. Shall I remove them?
  2. ms.topic: article seems to be replaced by ms.topic: conceptual.

If so, docs/styleguide/template.md also needs minor updating.

@imba-tjd imba-tjd changed the title [WIP] Update metadata Update metadata and example Nov 18, 2018
@rpetrusha
Copy link
Contributor

Closing and reopening to begin new build.

@rpetrusha rpetrusha closed this Nov 19, 2018
@rpetrusha rpetrusha reopened this Nov 19, 2018
@mairaw
Copy link
Contributor

mairaw commented Nov 19, 2018

You're right @imba-tjd. I'll review the topics that are still using ms.topic article to remove them all in a separate PR.

@BillWagner
Copy link
Member

@mairaw Can you look at this one? The conflicts are all in the metadata section, and it looks like the PR may have been caught in the recent changes you were making across many topics.

@mairaw mairaw closed this Dec 4, 2018
@mairaw mairaw reopened this Dec 4, 2018
@mairaw
Copy link
Contributor

mairaw commented Dec 4, 2018

@BillWagner yes they did. It should be fixed now.

@mairaw
Copy link
Contributor

mairaw commented Dec 4, 2018

@meganbradley because I merged the master branch to this PR, the commit validation report is showing things that are not applicable to the PR itself.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @imba-tjd for your contribution. Your changes should show up live within a day or so.

@mairaw mairaw merged commit d4259cc into dotnet:master Dec 4, 2018
@imba-tjd imba-tjd deleted the patch-1 branch December 19, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants