Nullable reference types tutorial, and nullable references overview #9345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
added
the
🚧 Hold for related PR
|
Closing and reopening to begin new build after dotnet/samples#491 was merged. |
BillWagner
removed
the
🚧 Hold for related PR
rpetrusha
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
This looks good, @BillWagner. This is an outstanding example. I've left a number of nits and minor suggestions. You can merge when you're ready.
mairaw
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
Really cool stuff @BillWagner! Left some comments for you to consider.
|
And I just noticed @rpetrusha had submitted his review while I was going through the PR. It seems some are duplicate which reinforces more the comments. 😄 |
pkulikov
reviewed
Dec 4, 2018
|
@mairaw was reviewing as well during my reading. Duplicate feedback is not intended :). |
|
Thanks for all the feedback @mairaw @rpetrusha @pkulikov! It really improves this article. 🎆 🍾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8208
Fixes #8204
Relies on dotnet/samples#491
Add the overview and first tutorial for nullable reference types.
Overview preview link
Tutorial link