Revised .NET Framework version detection article #9954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Closing and reopening to begin new build with the latest version of the examples. |
Contributor
|
@rpetrusha Since you are in here revamping this, want to take #9174 into consideration? I had that on my todo for next sprint. I guess you're kind of doing it for the other bug 👍 Probably can just link to it with the |
Contributor
Author
Contributor
|
@rpetrusha Is it possible to make known that there are community provided tools to help detection? Such as https://github.com/EliteLoser/DotNetVersionLister |
BillWagner
approved these changes
Feb 19, 2019
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Sorry for delay in getting everything reviewed @rpetrusha
This LGTM, and is ready to 
| --- | ||
| title: "How to: Determine which .NET Framework versions are installed" | ||
| ms.date: "04/10/2018" | ||
| ms.date: "01/11/2019" |
Member
There was a problem hiding this comment.
given the delay in review time 😢 , you may want to update the date to today's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised .NET Framework version detection article
Fixes #3991
Fixes #9174
Fixes #9267
Related to dotnet/samples#564
Review URLs: