Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation on Marshal.GetLastWin32Error should be updated. #1123

Closed
danmoseley opened this issue Jun 29, 2017 · 1 comment
Closed

Documentation on Marshal.GetLastWin32Error should be updated. #1123

danmoseley opened this issue Jun 29, 2017 · 1 comment
Labels
area-System.Runtime.InteropServices Pri3 Indicates issues/PRs that are low priority untriaged New issue has not been triaged by the area owner

Comments

@danmoseley
Copy link
Member

@tannergooding commented on Wed Jun 28 2017

The documentation currently makes no mention that this method will return errno on Unix/Mac (or the conditions, if any, under which it will return errno on Windows).

@tannergooding commented on Wed Jun 28 2017

As an aside, GetLastWin32Error is really a terrible name for cross-platform use. Maybe adding a new API GetLastError would be better...

@mellinoe commented on Wed Jun 28 2017

Many of the function names in Marshal are Windows-specific. There was some effort to introduce a PInvokeMarshal class which had better, platform-agnostic names, but I think we decided it wasn't worth it.

@tannergooding commented on Thu Jun 29 2017

Fair enough.

At the very least, documenting interop/marshalling functions with the behavior they take on non-Windows would be very beneficial.
@BillWagner BillWagner transferred this issue from dotnet/docs Nov 20, 2018
@dotnet-bot dotnet-bot added untriaged New issue has not been triaged by the area owner and removed rerun-labels labels Nov 20, 2018
@PRMerger13 PRMerger13 added the Pri3 Indicates issues/PRs that are low priority label Nov 11, 2020
@AaronRobinsonMSFT
Copy link
Member

Updated with #7334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Runtime.InteropServices Pri3 Indicates issues/PRs that are low priority untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@BillWagner @danmoseley @dotnet-bot @jozkee @PRMerger13 @AaronRobinsonMSFT