Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remarks to last error Marshal APIs #7334

Merged
merged 5 commits into from
Nov 5, 2021
Merged

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Oct 29, 2021

Summary

Add some more details to the last system error and last p/invoke error Marshal APIs that were added in .NET 6.0.

cc @AaronRobinsonMSFT @jkoritzinsky

@opbld34
Copy link

opbld34 commented Oct 29, 2021

Docs Build status updates of commit 6361b54:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Runtime.InteropServices/Marshal.xml ⚠️Warning View Details
samples/snippets/csharp/VS_Snippets_CLR/Runtime.InteropServices.Marshal.GetLastPInvokeError/cs/example.cs ✅Succeeded View
xml/System.Runtime.InteropServices/DllImportAttribute.xml ✅Succeeded View

xml/System.Runtime.InteropServices/Marshal.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.Marshal.GetLastPInvokeError(System.Int32)'.
  • Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
  • Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld30
Copy link

opbld30 commented Oct 29, 2021

Docs Build status updates of commit e7a7126:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Runtime.InteropServices/Marshal.xml ⚠️Warning View Details
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/GetLastPInvokeError.cs ✅Succeeded View
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/Marshal.csproj ✅Succeeded
xml/System.Runtime.InteropServices/DllImportAttribute.xml ✅Succeeded View

xml/System.Runtime.InteropServices/Marshal.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.Marshal.GetLastPInvokeError(System.Int32)'.
  • Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
  • Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

xml/System.Runtime.InteropServices/DllImportAttribute.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/Marshal.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/Marshal.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/Marshal.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/Marshal.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/Marshal.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/Marshal.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/Marshal.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/Marshal.xml Outdated Show resolved Hide resolved
@opbld31
Copy link

opbld31 commented Oct 29, 2021

Docs Build status updates of commit 612e304:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/GetLastPInvokeError.cs ✅Succeeded View
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/Marshal.csproj ✅Succeeded
xml/System.Runtime.InteropServices/DllImportAttribute.xml ✅Succeeded View
xml/System.Runtime.InteropServices/Marshal.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @elinor-fung

@opbld32
Copy link

opbld32 commented Oct 29, 2021

Docs Build status updates of commit fa4b14a:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/GetLastPInvokeError.cs ✅Succeeded View
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/Marshal.csproj ✅Succeeded
xml/System.Runtime.InteropServices/DllImportAttribute.xml ✅Succeeded View
xml/System.Runtime.InteropServices/Marshal.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld34
Copy link

opbld34 commented Oct 29, 2021

Docs Build status updates of commit 25c67d2:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Runtime.InteropServices/Marshal.xml ⚠️Warning View Details
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/GetLastPInvokeError.cs ✅Succeeded View
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/Marshal.csproj ✅Succeeded
xml/System.Runtime.InteropServices/DllImportAttribute.xml ✅Succeeded View

xml/System.Runtime.InteropServices/Marshal.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.Marshal.GetWin32Error*'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld31
Copy link

opbld31 commented Oct 29, 2021

Docs Build status updates of commit 142b27a:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot
  • Line 0, Column 0: [Warning: missing-attribute] Missing required attribute: 'name'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
Copy link
Contributor

Close/reopen for fresh build.

@gewarren gewarren closed this Oct 29, 2021
@gewarren gewarren reopened this Oct 29, 2021
@opbld34
Copy link

opbld34 commented Oct 29, 2021

Docs Build status updates of commit 142b27a:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/GetLastPInvokeError.cs ✅Succeeded View
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/Marshal.csproj ✅Succeeded
xml/System.Runtime.InteropServices/DllImportAttribute.xml ✅Succeeded View
xml/System.Runtime.InteropServices/Marshal.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Nov 1, 2021

Docs Build status updates of commit e07ed2b:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/GetLastPInvokeError.cs ✅Succeeded View
samples/snippets/csharp/System.Runtime.InteropServices/Marshal/Marshal.csproj ✅Succeeded
xml/System.Runtime.InteropServices/DllImportAttribute.xml ✅Succeeded View
xml/System.Runtime.InteropServices/Marshal.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants