Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROPC fixes for System.ServiceModel and System.Net #10730

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Dec 7, 2024

Contributes to #10434.

Hide whitespace changes in diff.

@gewarren gewarren requested review from HongGit, mconnew and a team as code owners December 7, 2024 01:26
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Dec 7, 2024

This comment was marked as outdated.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready

Copy link

Learn Build status updates of commit f704304:

✅ Validation status: passed

File Status Preview URL Details
snippets/cpp/VS_Snippets_Remoting/Classic HttpWebRequest.ConnectionGroupName Example/CPP/source.cpp ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Net/WebRequest/PreAuthenticate/Project.csproj ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Net/WebRequest/PreAuthenticate/webrequest_preauthenticate.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_CFX/c_claimset/cs/makefile ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_CFX/c_claimset/cs/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_CFX/c_claimset/cs/service.cs ✅Succeeded View
snippets/csharp/VS_Snippets_CFX/c_iauthorizationpolicy/cs/makefile ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_CFX/c_iauthorizationpolicy/cs/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_CFX/c_iauthorizationpolicy/cs/service.cs ✅Succeeded View
snippets/csharp/VS_Snippets_CFX/c_usernamevalidator/cs/makefile ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_CFX/c_usernamevalidator/cs/service.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_CFX/s_ueservicecredentials/cs/app.config ✅Succeeded
snippets/csharp/VS_Snippets_CFX/s_ueservicecredentials/cs/cs.csproj ✅Succeeded
snippets/csharp/VS_Snippets_CFX/s_ueservicecredentials/cs/makefile ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_CFX/s_ueservicecredentials/cs/program.cs ✅Succeeded View
snippets/csharp/VS_Snippets_CFX/s_ueservicecredentials/cs/service.cs ✅Succeeded
snippets/csharp/VS_Snippets_CFX/s_ueusernamepasswordvalidationmode/cs/makefile ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_CFX/s_ueusernamepasswordvalidationmode/cs/service.cs ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/c_claimset/vb/makefile ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/c_claimset/vb/myauthorizationpolicy.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CFX/c_claimset/vb/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CFX/c_usernamevalidator/vb/makefile ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/c_usernamevalidator/vb/service.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/s_uewindowsservicecredential/vb/makefile ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/s_uewindowsservicecredential/vb/Project.vbproj ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 08326ff into dotnet:main Dec 11, 2024
4 checks passed
@gewarren gewarren deleted the ropc-december-iii branch December 11, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants