Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken or unwanted link pathTooLongException #10746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ankush1oo8
Copy link

Summary

Describe your changes here.
In the remarks section, there's a link to Long Paths in .NET.

Now updated to

intended target of the link. I would be convenient if the link were updated.

Fixes #10404 (if available)

@Ankush1oo8 Ankush1oo8 requested a review from a team as a code owner December 10, 2024 09:22
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 10, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io

Copy link

Learn Build status updates of commit e4be09a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/PathTooLongException.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the runtime team to review as well. I had one comment on the URL format

@@ -66,7 +66,7 @@
## Remarks

> [!NOTE]
> This exception is not included in [.NET for Windows Store apps](https://go.microsoft.com/fwlink/?LinkID=247912) or the [Portable Class Library](/dotnet/standard/cross-platform/cross-platform-development-with-the-portable-class-library), but it is thrown by some members that are. To catch the exception in that case, write a `catch` statement that handles an <xref:System.IO.IOException> instead.
> This exception is not included in [.NET for Windows Store apps](https://learn.microsoft.com/en-us/dotnet/api/system.io.pathtoolongexception?view=net-8.0) or the [Portable Class Library](/dotnet/standard/cross-platform/cross-platform-development-with-the-portable-class-library), but it is thrown by some members that are. To catch the exception in that case, write a `catch` statement that handles an <xref:System.IO.IOException> instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The locale portion of the URL should be removed. That way, it redirects to the locale configured in the user's browser)

Suggested change
> This exception is not included in [.NET for Windows Store apps](https://learn.microsoft.com/en-us/dotnet/api/system.io.pathtoolongexception?view=net-8.0) or the [Portable Class Library](/dotnet/standard/cross-platform/cross-platform-development-with-the-portable-class-library), but it is thrown by some members that are. To catch the exception in that case, write a `catch` statement that handles an <xref:System.IO.IOException> instead.
> This exception is not included in [.NET for Windows Store apps](https://learn.microsoft.com/dotnet/api/system.io.pathtoolongexception?view=net-8.0) or the [Portable Class Library](/dotnet/standard/cross-platform/cross-platform-development-with-the-portable-class-library), but it is thrown by some members that are. To catch the exception in that case, write a `catch` statement that handles an <xref:System.IO.IOException> instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PathTooLongException contains invalid link
2 participants