Update docs for IsNNN extension methods on IHost(ing)Environment #4204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Wordsmithing recommendations very welcome! The general idea here is that "Environment" names are completely in the control of an application. We provide three default names (Development, Staging, Production) but it's completely up to the application. The linked bug (above) resolved into a request for some clarity on that in the API docs to guide library authors to avoid coupling behavior to specific names (using these APIs). |
Tratcher
approved these changes
May 7, 2020
Contributor
Author
|
What's needed to finish this PR? I don't have merge permissions :). |
ericstj
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update docs to clarify the purpose of the
IsNNNextension methods onIHostEnvironmentandIHostingEnvironmentas being specifically for end-applications.Fixes dotnet/extensions#3054