Skip to content

.NET Interactive: Enable_try_dotnet_to_batch_8a #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2020
Merged

.NET Interactive: Enable_try_dotnet_to_batch_8a #4222

merged 1 commit into from
May 15, 2020

Conversation

@v-mepa
Copy link
Contributor

@v-mepa v-mepa commented May 12, 2020

Enable_try_dotnet_to_batch_8a

URL Comments
https://docs.microsoft.com/en-us/dotnet/api/system.char.isletter Duplicate samples for all overloads? Potentially move it to the MemberGroup

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 12, 2020
@v-mepa
Copy link
Contributor Author

v-mepa commented May 12, 2020

FYI @mairaw, please review and let me know if this looks good.

@mairaw mairaw self-requested a review May 15, 2020 21:27
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label May 15, 2020
mairaw
mairaw approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@mairaw mairaw merged commit e63b478 into dotnet:master May 15, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_8a branch May 15, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

No one assigned

Labels

👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

3 participants

@v-mepa @mairaw @dotnet-bot