Skip to content

SslApplicationProtocol: update documentation #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2020
Merged

SslApplicationProtocol: update documentation #4350

merged 6 commits into from
Jun 16, 2020

Conversation

@aik-jahoda
Copy link
Contributor

@aik-jahoda aik-jahoda commented Jun 9, 2020

Summary

Collect all changes from #3916 related to SslApplicationProtocol

@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 9, 2020
@aik-jahoda aik-jahoda requested a review from wfurt June 9, 2020 13:01
@carlossanlop carlossanlop mentioned this pull request Jun 9, 2020
Closed
wfurt
wfurt reviewed Jun 9, 2020
View reviewed changes
wfurt
wfurt approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks ok to me. You should probably check with docs people about the language.

mairaw
mairaw reviewed Jun 10, 2020
View reviewed changes
mairaw
mairaw reviewed Jun 10, 2020
View reviewed changes
@aik-jahoda @mairaw
Update xml/System.Net.Security/SslApplicationProtocol.xml
bb83263 
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
@wfurt
Copy link
Member

wfurt commented Jun 10, 2020

Is there link to generated documentation? I think there is but I cannot find it ;(

@aik-jahoda @mairaw
Update xml/System.Net.Security/SslApplicationProtocol.xml
b84ac7a 
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
@aik-jahoda
Copy link
Contributor Author

aik-jahoda commented Jun 12, 2020

@wfurt, the preview is there https://review.docs.microsoft.com/en-us/dotnet/api/system.net.security.sslapplicationprotocol?branch=pr-en-us-4350&view=netcore-3.1

@aik-jahoda aik-jahoda requested a review from wfurt June 15, 2020 08:38
@aik-jahoda aik-jahoda mentioned this pull request Jun 15, 2020
Merged
wfurt
wfurt approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

xml/System.Net.Security/SslApplicationProtocol.xml Outdated
## Remarks
For list of supported protocols, see [TLS Application-Layer Protocol Negotiation (ALPN) Protocol IDs](https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml#alpn-protocol-ids).
This class contains static field with predefined <xref:System.Net.Security.SslApplicationProtocol> values for HTTP versions.
Copy link
Member

@wfurt wfurt Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part renders weird.

@aik-jahoda aik-jahoda merged commit f972e24 into dotnet:master Jun 16, 2020
@aik-jahoda aik-jahoda deleted the jajahoda/SslApplicationProtocol branch June 17, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw left review comments

@wfurt wfurt wfurt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

June 2020

Development

Successfully merging this pull request may close these issues.

4 participants

@aik-jahoda @wfurt @mairaw @dotnet-bot