Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http sync follow up #4905

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Http sync follow up #4905

merged 2 commits into from
Sep 23, 2020

Conversation

aik-jahoda
Copy link
Contributor

Summary

Follow up of #4776

@aik-jahoda aik-jahoda mentioned this pull request Sep 23, 2020
Merged
@opbld33
Copy link

opbld33 commented Sep 23, 2020

Docs Build status updates of commit ecd28b1:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml ❌Error Details
❌Error Details

xml/System.Net.Http/HttpClient.xml

  • Line 0, Column 0: [Error-ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: The 'Docs' start tag on line 2781 position 8 does not match the end tag of 'remarks'. Line 2787, position 11.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

  • Line 0, Column 0: [Error-ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...
  • Line 0, Column 0: [Error-file-not-found] Invalid file link: '.sourcemap-ecma-0.json'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

carlossanlop
carlossanlop approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for submitting.

@carlossanlop
Copy link
Member

Closing and reopening to re-trigger the CI.

@carlossanlop carlossanlop reopened this Sep 23, 2020
ManickaP
ManickaP approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fixes.

@opbld31
Copy link

opbld31 commented Sep 23, 2020

Docs Build status updates of commit ecd28b1:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml ❌Error Details
❌Error Details

xml/System.Net.Http/HttpClient.xml

  • Line 0, Column 0: [Error-ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: The 'Docs' start tag on line 2781 position 8 does not match the end tag of 'remarks'. Line 2787, position 11.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

  • Line 0, Column 0: [Error-ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...
  • Line 0, Column 0: [Error-file-not-found] Invalid file link: '.sourcemap-ecma-0.json'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld31
Copy link

opbld31 commented Sep 23, 2020

Docs Build status updates of commit d6bfcc6:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/ByteArrayContent.xml ✅Succeeded View
xml/System.Net.Http/DelegatingHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpContent.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageInvoker.xml ✅Succeeded View
xml/System.Net.Http/MessageProcessingHandler.xml ✅Succeeded View
xml/System.Net.Http/MultipartContent.xml ✅Succeeded View
xml/System.Net.Http/ReadOnlyMemoryContent.xml ✅Succeeded View
xml/System.Net.Http/StreamContent.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit b4bd52b into dotnet:net5-rc2 Sep 23, 2020
@carlossanlop carlossanlop deleted the jahoda/httpsync-followup branch September 23, 2020 20:03
gewarren pushed a commit to gewarren/dotnet-api-docs that referenced this pull request Sep 24, 2020
@gewarren
Http sync follow up (dotnet#4905)
1baf681 
* Add the http sync follow up

* Fix closing tag

Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>
carlossanlop added a commit that referenced this pull request Sep 24, 2020
@carlossanlop @tarekgh
@gewarren @jozkee @buyaa-n @bartonjs @aik-jahoda @ManickaP @Anipik
Rc2 doc comments (#4908)
0ae4e98 
* Automatic port of System.OperatingSystem docs for RC2 (#4852)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

* Add Missing System.Diagnostics docs (#4856)

* Add Missing System.Diagnostics docs

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>

* Automatically port System.Diagnostics docs for RC2 (#4853)

* Automatically port System.Diagnostics docs for RC2

* Update xml/System.Diagnostics/ActivitySamplingResult.xml

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>

* Update xml/System.Diagnostics/Process.xml

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>

* Automatic port of RegexParse* documentation (#4850)

* Automatic port of RegexParse* documentation

* Update xml/System.Text.RegularExpressions/RegexParseError.xml

* Apply suggestions from code review

* Update RegexParseException

* Update xml/System.Text.RegularExpressions/RegexParseException.xml

* Update xml/System.Text.RegularExpressions/RegexParseException.xml

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Prashanth Govindarajan <prgovi@microsoft.com>

* Add ssl API added between preview 7 and 8 (#4860)

* Automatic port of Reflection RC2 documentation (#4851)

* Revert "Add ssl API added between preview 7 and 8 (#4860)" (#4868)

This reverts commit 10d2b88.

* Add ssl API added between preview 7 and 8 #2 (#4869)

* Add ssl API added between preview 7 and 8

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Update xml/System.Net.Security/SslStream.xml

* Apply @wfurt comments

* Add missing remark headers

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback (#4861)

* Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback

* Apply PR comments

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Add a remark to AddEvent method (#4871)

* Add a remark to AddEvent method

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Automatic port of CryptoStream docs (#4888)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

* Automatic port of System.Buffers docs (#4882)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

* resolve isprefix conflict

* Automatic port of System.Data.Common docs (#4885)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

* Automatic port of *PipeServerStreamAcl docs (#4880)

* Automatic port of *PipeServerStreamAcl docs

* Apply suggestions from code review

Co-authored-by: Prashanth Govindarajan <prgovi@microsoft.com>
Co-authored-by: David Cantú <dacantu@microsoft.com>

* Apply suggestions from code review

Co-authored-by: David Cantú <dacantu@microsoft.com>

* Apply suggestions from code review

* Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml

* Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Prashanth Govindarajan <prgovi@microsoft.com>
Co-authored-by: David Cantú <dacantu@microsoft.com>

* Automatic port of *OSPlatformAttribute docs (#4883)

* Automatic port of *OSPlatformAttribute docs

* Missing TargetPlatformAttribute constructor parameter description.

* Apply suggestions from code review

Co-authored-by: Buyaa <buyankhishig.namnan@microsoft.com>

* Update xml/System.Runtime.Versioning/SupportedOSPlatformAttribute.xml

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Buyaa <buyankhishig.namnan@microsoft.com>

* Document System.Enum (#4894)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

* Document Half.op_Explicit APIs (#4893)

* Document Half.op_Explicit APIs

* Equals

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

* Automatic port of Rune.CompareTo EII (#4891)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

* Add missing docs for AsnContentException. (#4895)

* Add missing documentation for S.S.Cryptography (#4892)

* Add missing documentation for S.S.Cryptography

* Apply feedback

* Automatic port of System.Threading.ExecutionContext.Restore doc (#4887)

* Automatic port of System.Threading.ExecutionContext.Restore doc

* Update xml/System.Threading/ExecutionContext.xml

Co-authored-by: Prashanth Govindarajan <prgovi@microsoft.com>

* Apply suggestions from code review

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Prashanth Govindarajan <prgovi@microsoft.com>

* Automatic port of  explicit interface implementation of System.Net.Http.HttpRequestOptions (#4881)

* Automatic port of explicit interface implementations for System.Net.Http.HttpRequestOptions

* Apply suggestions from code review

Co-authored-by: Jan Jahoda <aik.jahoda@post.cz>

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Jan Jahoda <aik.jahoda@post.cz>

* Document Type.IsAssignableTo (#4898)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

* Document System.PlatformID.Other (#4897)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

* HTTP Version Selection (#4870)

* Sync docs with source comments

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Add values

Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>

* HttpClient sync operations (#4776)

* Draft for @ManickaP

* Apply suggestions from code review

Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>

* Format verification

* Format verification

* Fix links

* Fix links

* Fix xml tag

* Fix links

* Fix links

* Fix links

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>

* Fix links

* Add CreateContentReadStream

* Fix links

* Add System.Net.Http.DelegatingHandler.Send

* Fix links

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>

* Remove "Synchronous" information from summary

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>

* Fix the  exception description

Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* adding docs for missing 5.0 apis for system.Runtime.CompilerServices.Unsafe  (#4902)

* adding docs for missing 5.0 apis

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>

* resolve conflict

* Add Sysytem.Net.* missing API (#4904)

* System.Net.Http.SocketsHttpHandler.EnableMultipleHttp2Connections

* Add Sysytem.Net.\* missing API

* Apply PR comments

* Apply suggestions from code review

* Apply suggestions from code review

* Update xml/System.Net.Http/SocketsHttpHandler.xml

Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>

* Http sync follow up (#4905)

* Add the http sync follow up

* Fix closing tag

Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
Co-authored-by: Prashanth Govindarajan <prgovi@microsoft.com>
Co-authored-by: Jan Jahoda <jajahoda@microsoft.com>
Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: David Cantú <dacantu@microsoft.com>
Co-authored-by: Buyaa <buyankhishig.namnan@microsoft.com>
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Co-authored-by: Jan Jahoda <aik.jahoda@post.cz>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@ManickaP ManickaP ManickaP approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aik-jahoda @opbld33 @carlossanlop @opbld31 @ManickaP @eiriktsarpalis