Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move System.IO.Compression.ZipFile* lengthy remarks to files #5363

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Feb 23, 2021

Based on @gewarren suggestion here, I am moving all the lengthy remarks from ZipFile.xml and ZipFileExtensions.xml to their own md files.

This PR is blocking dotnet/runtime#48633

@carlossanlop carlossanlop self-assigned this Feb 23, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-System.Security Issues related to security practices for .NET developers. label Feb 23, 2021
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop
Copy link
Member Author

OpenPublishing.Build is stuck and I want to see the preview. Closing and reopening to retrigger the CI.

@gewarren
Copy link
Contributor

OpenPublishing.Build is stuck and I want to see the preview. Closing and reopening to retrigger the CI.

OPS is down and will be for a few more days, unfortunately :(

@carlossanlop carlossanlop added area-System.IO.Compression and removed area-System.Security Issues related to security practices for .NET developers. labels Feb 26, 2021
@gewarren gewarren closed this Mar 3, 2021
@gewarren gewarren reopened this Mar 3, 2021
@carlossanlop carlossanlop reopened this Mar 3, 2021
@opbld33
Copy link

opbld33 commented Mar 3, 2021

Docs Build status updates of commit ac7af98:

✅ Validation status: passed

File Status Preview URL Details
includes/remarks/System.IO.Compression/ZipFile/Open.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipFile/ZipFile.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipFileExtensions/ZipFileExtensions.md ✅Succeeded View
xml/System.IO.Compression/ZipFile.xml ✅Succeeded View
xml/System.IO.Compression/ZipFileExtensions.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Mar 3, 2021

Docs Build status updates of commit ac7af98:

✅ Validation status: passed

File Status Preview URL Details
includes/remarks/System.IO.Compression/ZipFile/Open.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipFile/ZipFile.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipFileExtensions/ZipFileExtensions.md ✅Succeeded View
xml/System.IO.Compression/ZipFile.xml ✅Succeeded View
xml/System.IO.Compression/ZipFileExtensions.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Mar 4, 2021

Docs Build status updates of commit 496174d:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-GitCommitDoesNotExist] Cannot sync git repo to specified commit because commit 496174d9e4ed20e2094a8e61a6eabf5ed3d2fffe doesn't exist. It might be caused your branch is deleted or force pushed. If it is not this case, please open a ticket on https://SiteHelp

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop
Copy link
Member Author

Sorry for the spam, everyone. I pushed the wrong thing and a bunch of unrelated files got added to the PR which triggered the bot to add the owners.

@opbld34
Copy link

opbld34 commented Mar 4, 2021

Docs Build status updates of commit ade6972:

✅ Validation status: passed

File Status Preview URL Details
includes/remarks/System.IO.Compression/ZipFile/Open.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipFile/ZipFile.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipFileExtensions/ZipFileExtensions.md ✅Succeeded View
xml/System.IO.Compression/ZipFile.xml ✅Succeeded View
xml/System.IO.Compression/ZipFileExtensions.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit 519bd73 into dotnet:master Mar 4, 2021
@carlossanlop carlossanlop deleted the ZipFileRemarks branch March 4, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants