Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark SocketException versions #6894

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Mark SocketException versions #6894

merged 1 commit into from
Sep 14, 2021

Conversation

gewarren
Copy link
Contributor

Fixes #6658

@ghost
Copy link

ghost commented Jul 16, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #6658

Author: gewarren
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

@gewarren
Copy link
Contributor Author

@antonfirsov Can you review? Also, it seems like BeginConnect (string host, int port, AsyncCallback? requestCallback, object? state) never threw a SocketException?

@opbld34
Copy link

opbld34 commented Jul 16, 2021

Docs Build status updates of commit 4977406:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@antonfirsov
Copy link
Member

@gewarren on vacation now, if no one will be faster than me, will review by end of next week.

@karelz karelz requested a review from antonfirsov July 16, 2021 15:05
@gewarren
Copy link
Contributor Author

@antonfirsov Looks like no one else picked this up, so could you review it?

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Apologies for forgetting about this, hope we can still merge this on time.

@gewarren gewarren merged commit 16a582f into dotnet:main Sep 14, 2021
@gewarren gewarren deleted the begin-being branch September 14, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SokcetException from Begin*** methods for 6.0
3 participants