-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Update - .NET 7 RC 1 #8380
CI Update - .NET 7 RC 1 #8380
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results source_repo.branch:net7-rc1 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
This comment was marked as outdated.
This comment was marked as outdated.
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml
Show resolved
Hide resolved
Where does this error come from? Is this deleted file being referenced somewhere? |
You can ignore it. It's because that type was renamed to GeneratedRegexAttribute. |
* Update System.Formats.Tar docs (#8375) * Update tar docs * Apply suggestions from code review * Few more * Update xml/System.Formats.Tar/GnuTarEntry.xml * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> * Update xml/System.Formats.Tar/GnuTarEntry.xml Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> * Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry) Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> * Apply suggestions from code review * Fix bullet lists * Merge markdowns Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well. |
This comment was marked as outdated.
This comment was marked as outdated.
* System.Runtime.InteropServices.Javascript RC1 * First batch of suggestions by gewarren Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> * Next batch of suggestions by gewarren. * Apply suggestions from code review * It's -> This API is * Apply suggestions from code review Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> * Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Ankit Jain <radical@gmail.com>
* Assorted missing docs for RC1 * which -> that * which -> that * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> * Update xml/System.Diagnostics/TagList.xml Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@carlossanlop Are we good to merge this? If so can you approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.
Don't merge this yet, please. The WinForms PR is targeting this branch: #8393 |
Docs Build status updates of commit 57d3f9f: 💡 Validation status: suggestionsThis comment lists only the first 25 files in the pull request. xml/System.Net.Http.Headers/HeaderStringValues.xml
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml
xml/System.Numerics/BigInteger.xml
xml/System.Numerics/Complex.xml
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Nevermind, automerge 😄 |
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries