Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Update - .NET 7 RC 1 #8380

Merged
merged 6 commits into from
Sep 15, 2022
Merged

CI Update - .NET 7 RC 1 #8380

merged 6 commits into from
Sep 15, 2022

Conversation

gewarren
Copy link
Contributor

Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries

 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
 source_repo.branch:net7-rc1
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@ghost ghost assigned gewarren Sep 12, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Sep 12, 2022
@opbld33

This comment was marked as outdated.

@carlossanlop
Copy link
Member

File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.

Where does this error come from? Is this deleted file being referenced somewhere?

@gewarren
Copy link
Contributor Author

File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.

Where does this error come from? Is this deleted file being referenced somewhere?

You can ignore it. It's because that type was renamed to GeneratedRegexAttribute.

* Update System.Formats.Tar docs (#8375)

* Update tar docs

* Apply suggestions from code review

* Few more

* Update xml/System.Formats.Tar/GnuTarEntry.xml

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Update xml/System.Formats.Tar/GnuTarEntry.xml

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Apply suggestions from code review

* Fix bullet lists

* Merge markdowns

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34

This comment was marked as outdated.

@carlossanlop
Copy link
Member

Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well.

@opbld30

This comment was marked as outdated.

@carlossanlop
Copy link
Member

Incoming PRs: #8390 and #8391

carlossanlop and others added 2 commits September 15, 2022 09:13
* System.Runtime.InteropServices.Javascript RC1

* First batch of suggestions by gewarren

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Next batch of suggestions by gewarren.

* Apply suggestions from code review

* It's -> This API is

* Apply suggestions from code review

Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml

Co-authored-by: Ankit Jain <radical@gmail.com>

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
* Assorted missing docs for RC1

* which -> that

* which -> that

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Update xml/System.Diagnostics/TagList.xml

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31

This comment was marked as outdated.

@opbld30

This comment was marked as outdated.

@gewarren gewarren requested a review from a team as a code owner September 15, 2022 20:41
@gewarren
Copy link
Contributor Author

@carlossanlop Are we good to merge this? If so can you approve?

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.

@gewarren gewarren enabled auto-merge (squash) September 15, 2022 21:24
@carlossanlop
Copy link
Member

Don't merge this yet, please. The WinForms PR is targeting this branch: #8393

@opbld32
Copy link

opbld32 commented Sep 15, 2022

Docs Build status updates of commit 57d3f9f:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System.Net.Http.Headers/HeaderStringValues.xml 💡Suggestion View Details
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml 💡Suggestion View Details
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml 💡Suggestion View Details
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml 💡Suggestion View Details
xml/System.Numerics/BigInteger.xml 💡Suggestion View Details
xml/System.Numerics/Complex.xml 💡Suggestion View Details
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml 💡Suggestion n/a (file deleted) Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml ✅Succeeded
xml/FrameworksIndex/net-7.0.xml ✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml ✅Succeeded
xml/Microsoft.Extensions.Configuration/ConfigurationBinder.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceCollectionContainerBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/Host.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/HostBuilder.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/IHostEnvironment.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/IHostingEnvironment.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.Net.Http.Headers/HeaderStringValues.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#String}#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#Generic#IEnumerable{System#String}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#IEnumerable#GetEnumerator.

xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Reset.

xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#IEnumerable#GetEnumerator.

xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Reset.

xml/System.Numerics/BigInteger.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Numerics.BigInteger.op_UnsignedRightShift(System.Numerics.BigInteger,System.Int32).

xml/System.Numerics/Complex.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).

xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml

  • [Suggestion: file-not-redirected - See documentation] File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation] File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation] File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation] File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation] File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren merged commit 55d7a64 into main Sep 15, 2022
@gewarren gewarren deleted the net7-rc1 branch September 15, 2022 21:52
@carlossanlop
Copy link
Member

Nevermind, automerge 😄

@amzwzw

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants