Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add summary to Microsoft.Extensions.Options #8427

Merged

Conversation

ikesnowy
Copy link
Contributor

Summary

Just add the namespace document as the issue says it should be committed directly to this repo.

Contributes to dotnet/runtime#43919

@ikesnowy ikesnowy requested a review from a team as a code owner September 24, 2022 13:50
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 24, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld33
Copy link

opbld33 commented Sep 24, 2022

Docs Build status updates of commit 12c4461:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-Microsoft.Extensions.Options.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@MSDN-WhiteKnight
Copy link
Contributor

Consider also adding remarks with a link to related documentation (such as https://docs.microsoft.com/dotnet/core/extensions/options)

@ikesnowy
Copy link
Contributor Author

Consider also adding remarks with a link to related documentation (such as https://docs.microsoft.com/dotnet/core/extensions/options)

Added, thanks!

@opbld30
Copy link

opbld30 commented Sep 25, 2022

Docs Build status updates of commit f27d3b1:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-Microsoft.Extensions.Options.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Sep 25, 2022

Docs Build status updates of commit ed8503c:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-Microsoft.Extensions.Options.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@ghost
Copy link

ghost commented Sep 26, 2022

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Just add the namespace document as the issue says it should be committed directly to this repo.

Contributes to dotnet/runtime#43919

Author: ikesnowy
Assignees: -
Labels:

area-Extensions-Options, community-contribution

Milestone: -

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

xml/ns-Microsoft.Extensions.Options.xml Outdated Show resolved Hide resolved
xml/ns-Microsoft.Extensions.Options.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld30
Copy link

opbld30 commented Sep 30, 2022

Learn Build status updates of commit adb9305:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-Microsoft.Extensions.Options.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@tarekgh tarekgh merged commit bca162c into dotnet:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Extensions-Options community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants