Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix note on TcpClient constructor about IPv4 #8462

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Oct 5, 2022

Fixes #8075.

Behavior changed by dotnet/corefx#30036. So I assume it is enough to specify that the note is only valid for .NET Framework.

@rzikm rzikm requested a review from a team as a code owner October 5, 2022 14:33
@rzikm rzikm changed the title Fix note on tcpclient ctor Fix note on TcpClient constructor about IPv4 Oct 5, 2022
@ghost ghost assigned rzikm Oct 5, 2022
@ghost
Copy link

ghost commented Oct 5, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #8075.

Behavior changed by dotnet/corefx#30036. So I assume it is enough to specify that the note is only valid for .NET Framework.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net

Milestone: -

Copy link
Member

@liveans liveans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Oct 5, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #8075.

Behavior changed by dotnet/corefx#30036. So I assume it is enough to specify that the note is only valid for .NET Framework.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net.Sockets

Milestone: -

@opbld30
Copy link

opbld30 commented Oct 5, 2022

Learn Build status updates of commit a95fa2a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/TcpClient.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@rzikm rzikm merged commit 8b7a4fc into dotnet:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TcpClient constructor docs misleading
3 participants