Skip to content

Replaced token text, deleted win token #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2018
Merged

Replaced token text, deleted win token #85

merged 1 commit into from
Apr 26, 2018

Conversation

@rpetrusha
Copy link

@rpetrusha rpetrusha commented Apr 26, 2018

Replaced token text, deleted win token

This PR does the following:

  • Replaces the tla2sharptla-win-md token with its text, "Windows".
  • Deletes the tla2sharptla-win-md token.
  • Replaces a number of WPF tokens with their token text.

@rpetrusha rpetrusha self-assigned this Apr 26, 2018
@rpetrusha
Copy link
Author

rpetrusha commented Apr 26, 2018

This removes the token text and token from the dotnet/dotnet-api-docs repo; it was previously removed from the dotnet/docs repo by PR 5045.

mairaw
mairaw approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw
Copy link
Contributor

mairaw commented Apr 26, 2018

Not sure why WIP is still waiting

@rpetrusha rpetrusha changed the title Replaced token text, deleted win token [WIP] Replaced token text, deleted win token Apr 26, 2018
@rpetrusha rpetrusha changed the title [WIP] Replaced token text, deleted win token Replaced token text, deleted win token Apr 26, 2018
@rpetrusha rpetrusha merged commit 97cb2a9 into dotnet:master Apr 26, 2018
@rpetrusha rpetrusha deleted the win-token branch April 26, 2018 22:37
@eiriktsarpalis eiriktsarpalis added the area-WPF Issues or PRs that relate to WPF or XAML. label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@rpetrusha rpetrusha

Labels

area-WPF Issues or PRs that relate to WPF or XAML.

Projects

None yet

Milestone

Sprint 134 (4/7/2018 - 4/27/2018)

Development

Successfully merging this pull request may close these issues.

3 participants

@rpetrusha @mairaw @eiriktsarpalis