Replaced winfx token with token text, deleted token #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
approved these changes
Apr 27, 2018
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
Changes look great. left two comments not related to your changes if you'd like to address them.
| Using <xref:System.Windows.Navigation.NavigationService.AddBackEntry%2A>, you can also remember multiple sets of state for a single page instance. | ||
| <xref:System.Windows.Navigation.NavigationService> is `sealed` class and, therefore, cannot be instantiated; instead, <xref:System.Windows.Navigation.NavigationService> is used by navigators to enable navigation. In [!INCLUDE[TLA2#tla_wpf](~/includes/tla2sharptla-wpf-md.md)], there are two navigators: <xref:System.Windows.Navigation.NavigationWindow>, <xref:System.Windows.Controls.Frame>. | ||
| <xref:System.Windows.Navigation.NavigationService> is `sealed` class and, therefore, cannot be instantiated; instead, <xref:System.Windows.Navigation.NavigationService> is used by navigators to enable navigation. In WPF, there are two navigators: <xref:System.Windows.Navigation.NavigationWindow>, <xref:System.Windows.Controls.Frame>. |
Contributor
There was a problem hiding this comment.
not related to your change: replace last comma with an and?
| ## Remarks | ||
| To aid back and forward navigation, <xref:System.Windows.Navigation.NavigationWindow> automatically displays a navigation [!INCLUDE[TLA2#tla_ui](~/includes/tla2sharptla-ui-md.md)] | ||
| To aid back and forward navigation, <xref:System.Windows.Navigation.NavigationWindow> automatically displays a navigation UI |
Contributor
There was a problem hiding this comment.
not related to your chnages: missing comma
Author
|
Thanks, @mairaw. I've addressed both of your comments in the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced winfx token with token text, deleted token
This PR:
The token was replaced with its text and the token removed from the dotnet/docs repo by dotnet/docs#5052.