Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Linux tags do not match directory structure #1176

Closed
MichaelSimons opened this issue Aug 13, 2024 · 4 comments · Fixed by #1188
Closed

Azure Linux tags do not match directory structure #1176

MichaelSimons opened this issue Aug 13, 2024 · 4 comments · Fixed by #1188
Assignees

Comments

@MichaelSimons
Copy link
Member

See the src folder structure policy: https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/README.md#source-folder-structure. This has a long standing policy of the repo. It helps in navigating the repo to find the Dockerfile given a tag. There is no test that enforces this.

Example:

          "platforms": [
            {
              "dockerfile": "src/azurelinux/3.0/net9.0/crossdeps-llvm/amd64",
              "os": "linux",
              "osVersion": "azurelinux3.0",
              "tags": {
                "azurelinux-3.0-crossdeps-llvm-net9.0$(FloatingTagSuffix)": {},
                "azurelinux-3.0-crossdeps-llvm-net9.0-local": {
                  "isLocal": true
                }
              }
            }

There are two options to correct this:

  • Rename the tag to: azurelinux-3.0-net9.0-crossdeps-llvm-amd64
  • Restructure the folder path to: src/azurelinux/3.0/crossdeps-llvm/amd64/net9.0

I understand the desire to group all netx.y related Dockerfiles under a folder.

My recommendation if the decision is to make a change to the tagging, add the new tag for a period of time until all usage is migrated to the new tag and then remove the old tag.

@MichaelSimons
Copy link
Member Author

MichaelSimons commented Aug 13, 2024

cc @sbomer, @mthalman, @jkoritzinsky

@MichaelSimons
Copy link
Member Author

Related to #1035

@sbomer
Copy link
Member

sbomer commented Aug 13, 2024

I have no objection to renaming the tags to azurelinux-3.0-net9.0-crossdeps-llvm-amd64.

@richlander
Copy link
Member

If we're going to rename the tags (which is fine), we need to ensure we catch all the cases in runtime (and anywhere else they are used).

sbomer added a commit that referenced this issue Aug 20, 2024
The isLocal images have been renamed, and the others have had new tags
added so that we can migrate before removing the old tags.

See
#1176.
sbomer added a commit to dotnet/diagnostics that referenced this issue Aug 21, 2024
sbomer added a commit to dotnet/sdk that referenced this issue Aug 21, 2024
sbomer added a commit to dotnet/runtime that referenced this issue Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants