Get centos:7 images updated #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
approved these changes
Apr 19, 2024
lbussell
reviewed
Apr 19, 2024
Comment on lines
+5
to
+9
| RUN \ | ||
| # Since the base image isn't actively maintained, force an upgrade of existing packages | ||
| yum update -y \ | ||
| && \ | ||
| yum install -y \ |
There was a problem hiding this comment.
This will make the dependency layer really large since the image hasn't been updated in a long time. What is the layer size difference caused by this change, and if it's big (relative to the size of the entire image), will you consider squashing this into a single layer with the base image e.g. https://stackoverflow.com/a/77052183/13771378
There was a problem hiding this comment.
It's not that large: 50 MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #988