Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Y2038 support: Target Ubuntu 22.04 in arm build image #1037

Merged
merged 4 commits into from
May 8, 2024
Merged

Y2038 support: Target Ubuntu 22.04 in arm build image #1037

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea7ebe4
Update arm rootfs to 22.04
sbomer May 6, 2024
5408019
Adjust cxxabi header paths
sbomer May 6, 2024
e5132a5
Add comment
sbomer May 6, 2024
ef7fb40
Merge remote-tracking branch 'origin/main' into 64bitTimeT
sbomer May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/azurelinux/3.0/cross/arm-net9.0/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
FROM mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-crossdeps-builder-net9.0-local AS builder
ARG ROOTFS_DIR=/crossrootfs/arm

RUN /scripts/eng/common/cross/build-rootfs.sh arm xenial --skipunmount
# The arm rootfs targets Ubuntu 22.04, which is the first version with a
# glibc that supports 64-bit time_t. See https://github.com/dotnet/core/discussions/9285.
RUN /scripts/eng/common/cross/build-rootfs.sh arm jammy no-lldb --skipunmount
Copy link
Member

@agocke agocke May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this supports 64-bit time_t, but there's #define needed to actually use it. Do we need to set that somewhere? Or is it set by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @am11 did this already in dotnet/runtime#100461.


# Build compiler-rt profile library for PGO instrumentation
RUN mkdir compiler-rt_build && cd compiler-rt_build && \
Expand Down
Loading