-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python-pip3 to the list of Ubuntu apt package dependencies #681
Add python-pip3 to the list of Ubuntu apt package dependencies #681
Conversation
This is needed for dotnet/runtime#74961, where it appears that only 18.04 is needed, but it makes sense to add it to all the versions to support possible future version roll forward. |
/azp run dotnet-buildtools-prereqs-docker-ubuntu |
Azure Pipelines successfully started running 1 pipeline(s). |
@mthalman Thanks for triggering the run; I wasn't aware of this. Unfortunately, there seem to be a lot of presumably unrelated failures, so how do I interpret the results? |
@BruceForstall - That's normally not needed. It was needed because things weren't working from the dnceng-public migration. Getting close to having things in a working state. |
You will need to update references under eng/pipeline/coreclr/.... @BruceForstall |
@wfurt Thanks. I found the container references in https://github.com/dotnet/runtime/blob/main/eng/pipelines/common/platform-matrix.yml. I presume the newly built containers are available for reference. PR'ed change: dotnet/runtime#75167 Thanks all! |
yes, dotnet/runtime#75167 looks right to me. |
Ok, it looks like there's some step missing. In this PR, the build of "Linux_amd64 src-ubuntu-18.04-coredeps-graph", step "Build Images", includes:
But my PR to use these new images: is failing with:
|
The latest (link from top page) https://github.com/dotnet/versions/blob/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json |
I'm not sure where you look. But when PR is merged it would kick another build on "official" internal machine pool and it would publish images from there. |
ok, makes sense. I see an internal build pipeline dotnet-buildtools-prereqs-docker-ubuntu that picked up my change, but it looks like it was manually cancelled by @mthalman ? https://dev.azure.com/dnceng/internal/_build?definitionId=443&_a=summary |
Bottom-line: the build @wfurt refers to doesn't include my changes, it only include changes up to the previous change. |
I canceled the build because another merged PR already had a build running. We try to avoid have simultaneous builds for the same pipeline because that can result in unnecessary waste of resources by not taking advantage of our image caching functionality. I have a new build running with these changes: https://dev.azure.com/dnceng/internal/_build/results?buildId=1986251&view=results. |
The new build finished, https://github.com/dotnet/versions/blob/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json is updated, I verified the published containers have pip3 (that I added), so I updated dotnet/runtime#75167 |
No description provided.