Build llvm using clang on mariner #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run dotnet-buildtools-prereqs-docker-cbl-mariner |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mthalman
approved these changes
Apr 12, 2023
|
@mthalman this is ready to merge. Thanks! |
This was referenced Apr 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was building with gcc 11.2.0 (which is installed as an indirect dependency of
git, throughperl). Building with gcc 11.2.0 hit this bug: dotnet/runtime#84503.Using clang to compile llvm avoids the issue described there. I also couldn't reproduce the crash with llvm 16 regardless of compiler used to build llvm. However, I figure it's best to use clang here to be safe.
@janvorli @mthalman PTAL