Update SDK image first run handling #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The change look good. I have a couple requests.
- Can you make this PR against nightly? We should not be making this change in main without a tag change even though 6.0 is in preview.
- Can update the SDK ENV tests to ensure the variables and values to not regress - https://github.com/dotnet/dotnet-docker/blob/main/tests/Microsoft.DotNet.Docker.Tests/SdkImageTests.cs#L50
mthalman
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
@richlander - Can you update the description of this PR so that we have a record of the background and reasons for these changes?
|
Good call. Done. |
22 tasks
mthalman
pushed a commit
to mthalman/dotnet-docker
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reviewed the first run experience of our SDK Dockerfiles. Each one of them has a call to
dotnet helpto ensure that the first run experience is run in the Dockerfile instead of on first (which is every) run of the container.We decided to take a two step approach:
dotnet initcommand to better support this scenario.This PR is step 1.