Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Json as default console logging formatter in aspnet images for 6.0 #3703

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

mthalman
Copy link
Member

The change to default this to Json in 6.0 has been problematic for some customers as evidenced by the thread in #2725. We're making a breaking change to revert this back to the original behavior as announced in #3642. This leaves the Logging__Console__FormatterName environment variable unset.

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VerifyEnvironmentVariables tests are going to need updating for the aspnet and sdk images

e.g. - https://github.com/dotnet/dotnet-docker/blob/nightly/tests/Microsoft.DotNet.Docker.Tests/AspnetImageTests.cs#L64

@mthalman mthalman added the needs-announcement An announcement is needed to discuss customer impact label Apr 14, 2022
@mthalman mthalman merged commit ed4abcb into dotnet:nightly Apr 14, 2022
@mthalman mthalman deleted the console-formatter branch April 14, 2022 14:56
mthalman added a commit to mthalman/dotnet-docker that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure needs-announcement An announcement is needed to discuss customer impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants