Add more instructions #4413

richlander · 2023-02-12T05:19:01Z

For building platform-specific images (or not).
Enabling (or disabling) globalization (and potentially reducing size)

Please review @tarekgh

samples/aspnetapp/Dockerfile.alpine-icu

samples/aspnetapp/Dockerfile.alpine

samples/aspnetapp/README.md

samples/build-for-a-platform.md

mthalman · 2023-02-13T16:00:55Z

samples/build-for-a-platform.md

+
+In addition, Docker [Buildkit exposes multiple environment variables](https://github.com/dotnet/dotnet-docker/pull/4387#issuecomment-1416565213) that can be used to further conditionalize behavior. These environment variables can be controlled with the pattern demonstrated in [Dockerfile](https://github.com/mthalman/dredge/blob/main/src/Valleysoft.Dredge/Dockerfile). As mentioned, .NET doesn't support being run in emulation. The pattern in that Dockerfile results in the SDK always being run natively while the final image is affected by the `--platform` switch. This model also has the best performance since the bulk of computation is run natively.
+
+Note: We are enabling the following model in a future release: https://github.com/dotnet/dotnet-docker/issues/4388#issuecomment-1421401384.


Why not make these changes as part of this PR? I think it'd be more appropriate to reference the Dockerfile in this repo rather than the Dredge Dockerfile.

I plan to switch that PR to use the new format and then block on merging it until it is ready.

samples/build-for-a-platform.md

samples/enable-globalization.md

Co-authored-by: Matt Thalman <mthalman@microsoft.com>

mthalman · 2023-02-14T13:50:56Z

samples/enable-globalization.md

+docker run --rm -it -e TZ=$(cat /etc/timezone) app
+```
+
+This approach enables a container image to be launched matching the host, as opposed to setting the information as part of `docker build`.


enables a container image to be launched matching the host

Is that a common practice? In the world of cloud computing, what time zone the host is in seems irrelevant. I did a quick search and couldn't find any examples that use the host time zone. All are either hardcoding it or have it set to an environment variable that can be set dynamically. That approach seems better to me.

See this PR: #4414

What do you think @Clockwork-Muse?

samples/aspnetapp/Dockerfile.alpine-icu

MichaelSimons · 2023-02-14T15:14:56Z

samples/aspnetapp/Dockerfile.alpine-icu

+COPY aspnetapp/. .
+RUN dotnet publish --use-current-runtime -c Release --self-contained false --no-restore -o /app
+
+# To enable globalization support, see


The wording To enable globalization is a bit confusing because globalization is already enabled. Maybe something like To read more about globalization support, see...

MichaelSimons · 2023-02-14T15:20:12Z

samples/build-for-a-platform.md

+
+## Dockerfiles that build everywhere
+
+The default scenario is using multi-arch tags, which will work in multiple environments.


Will the reader understand the multi-arch nomenclature here? The earlier link referred to these are multi-platform images.

MichaelSimons · 2023-02-14T15:21:02Z

samples/build-for-a-platform.md

+docker build -t app .
+```
+
+It can be built on any supported operating system and architecture. For example, if built on an Apple M1 machine, Docker will produce a `linux/arm64` image, while on a Windows x64 machine, it will produce a `linux/amd64` image.


while on a Windows x64 machine, it will produce a linux/amd64 image

Not if your windows machine is configured for Windows containers :)

Yes. I was being lazy.

MichaelSimons · 2023-02-14T15:27:47Z

samples/build-for-a-platform.md

+
+Docker Desktop uses [QEMU](https://www.qemu.org/) for emulation, for example running x64 code on an Arm64 machine. [.NET doesn't support being run in QEMU](https://github.com/dotnet/core/blob/main/release-notes/7.0/supported-os.md#qemu). That means that the SDK needs to always be run natively, to enable [multi-stage build](https://docs.docker.com/build/building/multi-stage/). Multi-stage build is used by all of our samples.
+
+As a result, we need a reliable pattern that enables produces multiple variants of images on one machine, but that doesn't use emulation.


Broken wording - that enables produces multiple variants

Co-authored-by: Michael Simons <msimons@microsoft.com>

richlander · 2023-02-17T02:36:34Z

I believe I have addressed all feedback.

samples/enable-globalization.md

MichaelSimons · 2023-02-17T14:56:00Z

samples/enable-globalization.md

+
+### Alpine
+
+Install `tzdata`:


This section is formatted differently than the previous ICU section.

The previous section provided a Dockerfile snippet - e.g. a RUN instruction in a Dockerfile code block. It also didn't have an Install xxx prefix.

MichaelSimons · 2023-02-17T15:09:19Z

samples/build-for-a-platform.md

+For Linux containers on an x64 machine:
+
+```bash
+$ docker inspect app | jq .[0].Architecture


The docker CLI will do this for you and the nice thing is the command is platform agnostic.

docker inspect app -f "{{ .Architecture }}"

Thanks!

I submit to being a jq addict.

How do you like translating that into PowerShell 🥲

Co-authored-by: Michael Simons <msimons@microsoft.com>

richlander · 2023-02-17T20:46:42Z

I believe I have now addressed the feedback.

Great feedback, BTW.

Add extra instructions

e6c2661

dotnet-issue-labeler bot added the area-samples label Feb 12, 2023

Fix typo

96e0cab

richlander mentioned this pull request Feb 13, 2023

Add globalization sample #4414

Merged

mthalman reviewed Feb 13, 2023

View reviewed changes

richlander and others added 4 commits February 13, 2023 19:39

Apply suggestions from code review

be14437

Co-authored-by: Matt Thalman <mthalman@microsoft.com>

Add code sample for tzdata

b4c9be1

Update text

fa52783

Update per feedback

df7006b

mthalman reviewed Feb 14, 2023

View reviewed changes

MichaelSimons reviewed Feb 14, 2023

View reviewed changes

richlander requested a review from lbussell as a code owner February 14, 2023 15:50

richlander and others added 2 commits February 14, 2023 07:50

Update samples/aspnetapp/Dockerfile.alpine-icu

0369292

Co-authored-by: Michael Simons <msimons@microsoft.com>

Update per feedback

0859b0d

Update comment

3abe079

MichaelSimons reviewed Feb 17, 2023

View reviewed changes

richlander and others added 2 commits February 17, 2023 10:56

Apply suggestions from code review

a3699f6

Co-authored-by: Michael Simons <msimons@microsoft.com>

Update per feedback

013ad8d

MichaelSimons approved these changes Feb 17, 2023

View reviewed changes

richlander merged commit 10d5312 into dotnet:main Feb 17, 2023

richlander deleted the extra-instructions branch February 17, 2023 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more instructions #4413

Add more instructions #4413

richlander commented Feb 12, 2023 •

edited

Loading

mthalman Feb 13, 2023

richlander Feb 14, 2023

mthalman Feb 14, 2023

richlander Feb 14, 2023

MichaelSimons Feb 14, 2023

richlander Feb 17, 2023

MichaelSimons Feb 14, 2023

richlander Feb 17, 2023

MichaelSimons Feb 14, 2023

richlander Feb 17, 2023

MichaelSimons Feb 14, 2023

richlander commented Feb 17, 2023

MichaelSimons Feb 17, 2023

MichaelSimons Feb 17, 2023 •

edited

Loading

richlander Feb 17, 2023

MichaelSimons Feb 17, 2023

richlander commented Feb 17, 2023 •

edited

Loading


		In addition, Docker [Buildkit exposes multiple environment variables](https://github.com/dotnet/dotnet-docker/pull/4387#issuecomment-1416565213) that can be used to further conditionalize behavior. These environment variables can be controlled with the pattern demonstrated in [Dockerfile](https://github.com/mthalman/dredge/blob/main/src/Valleysoft.Dredge/Dockerfile). As mentioned, .NET doesn't support being run in emulation. The pattern in that Dockerfile results in the SDK always being run natively while the final image is affected by the `--platform` switch. This model also has the best performance since the bulk of computation is run natively.

		Note: We are enabling the following model in a future release: https://github.com/dotnet/dotnet-docker/issues/4388#issuecomment-1421401384.


		## Dockerfiles that build everywhere

		The default scenario is using multi-arch tags, which will work in multiple environments.


		Docker Desktop uses [QEMU](https://www.qemu.org/) for emulation, for example running x64 code on an Arm64 machine. [.NET doesn't support being run in QEMU](https://github.com/dotnet/core/blob/main/release-notes/7.0/supported-os.md#qemu). That means that the SDK needs to always be run natively, to enable [multi-stage build](https://docs.docker.com/build/building/multi-stage/). Multi-stage build is used by all of our samples.

		As a result, we need a reliable pattern that enables produces multiple variants of images on one machine, but that doesn't use emulation.


		### Alpine

		Install `tzdata`:

Add more instructions #4413

Add more instructions #4413

Conversation

richlander commented Feb 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richlander commented Feb 17, 2023

Choose a reason for hiding this comment

MichaelSimons Feb 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richlander commented Feb 17, 2023 • edited Loading

richlander commented Feb 12, 2023 •

edited

Loading

MichaelSimons Feb 17, 2023 •

edited

Loading

richlander commented Feb 17, 2023 •

edited

Loading