Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi-platform tags for Windows #4536

Merged
merged 1 commit into from
Apr 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.aspnet.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ Tag | Dockerfile
##### .NET 8 Preview Tags
Tag | Dockerfile
---------| ---------------
8.0.0-preview.3-nanoserver-ltsc2022, 8.0-preview-nanoserver-ltsc2022, 8.0.0-preview.3, 8.0-preview, latest | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/8.0/nanoserver-ltsc2022/amd64/Dockerfile)
8.0.0-preview.3-nanoserver-ltsc2022, 8.0-preview-nanoserver-ltsc2022 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/8.0/nanoserver-ltsc2022/amd64/Dockerfile)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarification, having no latest tag is desired, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. There will be a latest tag but it won't be useable from Windows anymore.


## Windows Server Core 2022 amd64 Tags
Tag | Dockerfile
Expand All @@ -147,7 +147,7 @@ Tag | Dockerfile
##### .NET 8 Preview Tags
Tag | Dockerfile
---------| ---------------
8.0.0-preview.3-nanoserver-1809, 8.0-preview-nanoserver-1809, 8.0.0-preview.3, 8.0-preview, latest | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/8.0/nanoserver-1809/amd64/Dockerfile)
8.0.0-preview.3-nanoserver-1809, 8.0-preview-nanoserver-1809 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/8.0/nanoserver-1809/amd64/Dockerfile)

## Windows Server Core 2019 amd64 Tags
Tag | Dockerfile
Expand Down
4 changes: 2 additions & 2 deletions README.runtime.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ Tag | Dockerfile
##### .NET 8 Preview Tags
Tag | Dockerfile
---------| ---------------
8.0.0-preview.3-nanoserver-ltsc2022, 8.0-preview-nanoserver-ltsc2022, 8.0.0-preview.3, 8.0-preview, latest | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/8.0/nanoserver-ltsc2022/amd64/Dockerfile)
8.0.0-preview.3-nanoserver-ltsc2022, 8.0-preview-nanoserver-ltsc2022 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/8.0/nanoserver-ltsc2022/amd64/Dockerfile)

## Windows Server Core 2022 amd64 Tags
Tag | Dockerfile
Expand All @@ -143,7 +143,7 @@ Tag | Dockerfile
##### .NET 8 Preview Tags
Tag | Dockerfile
---------| ---------------
8.0.0-preview.3-nanoserver-1809, 8.0-preview-nanoserver-1809, 8.0.0-preview.3, 8.0-preview, latest | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/8.0/nanoserver-1809/amd64/Dockerfile)
8.0.0-preview.3-nanoserver-1809, 8.0-preview-nanoserver-1809 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/8.0/nanoserver-1809/amd64/Dockerfile)

## Windows Server Core 2019 amd64 Tags
Tag | Dockerfile
Expand Down
4 changes: 2 additions & 2 deletions README.sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ Tag | Dockerfile
##### .NET 8 Preview Tags
Tag | Dockerfile
---------| ---------------
8.0.100-preview.3-nanoserver-ltsc2022, 8.0-preview-nanoserver-ltsc2022, 8.0.100-preview.3, 8.0-preview, latest | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/sdk/8.0/nanoserver-ltsc2022/amd64/Dockerfile)
8.0.100-preview.3-nanoserver-ltsc2022, 8.0-preview-nanoserver-ltsc2022 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/sdk/8.0/nanoserver-ltsc2022/amd64/Dockerfile)

## Windows Server Core 2022 amd64 Tags
Tag | Dockerfile
Expand All @@ -143,7 +143,7 @@ Tag | Dockerfile
##### .NET 8 Preview Tags
Tag | Dockerfile
---------| ---------------
8.0.100-preview.3-nanoserver-1809, 8.0-preview-nanoserver-1809, 8.0.100-preview.3, 8.0-preview, latest | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/sdk/8.0/nanoserver-1809/amd64/Dockerfile)
8.0.100-preview.3-nanoserver-1809, 8.0-preview-nanoserver-1809 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/sdk/8.0/nanoserver-1809/amd64/Dockerfile)

## Windows Server Core 2019 amd64 Tags
Tag | Dockerfile
Expand Down
174 changes: 102 additions & 72 deletions manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2239,26 +2239,6 @@
"8.0-preview-bookworm-slim-arm64v8": {}
},
"variant": "v8"
},
{
"dockerfile": "src/runtime/8.0/nanoserver-1809/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/runtime/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-1809",
"tags": {
"$(dotnet|8.0|product-version)-nanoserver-1809": {},
"8.0-preview-nanoserver-1809": {}
}
},
{
"dockerfile": "src/runtime/8.0/nanoserver-ltsc2022/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/runtime/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-ltsc2022",
"tags": {
"$(dotnet|8.0|product-version)-nanoserver-ltsc2022": {},
"8.0-preview-nanoserver-ltsc2022": {}
}
}
]
},
Expand Down Expand Up @@ -2627,6 +2607,36 @@
}
]
},
{
"productVersion": "$(dotnet|8.0|product-version)",
"platforms": [
{
"dockerfile": "src/runtime/8.0/nanoserver-1809/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/runtime/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-1809",
"tags": {
"$(dotnet|8.0|product-version)-nanoserver-1809": {},
"8.0-preview-nanoserver-1809": {}
}
}
]
},
{
"productVersion": "$(dotnet|8.0|product-version)",
"platforms": [
{
"dockerfile": "src/runtime/8.0/nanoserver-ltsc2022/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/runtime/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-ltsc2022",
"tags": {
"$(dotnet|8.0|product-version)-nanoserver-ltsc2022": {},
"8.0-preview-nanoserver-ltsc2022": {}
}
}
]
},
{
"productVersion": "$(dotnet|8.0|product-version)",
"platforms": [
Expand Down Expand Up @@ -3803,32 +3813,6 @@
"8.0-preview-bookworm-slim-arm64v8": {}
},
"variant": "v8"
},
{
"buildArgs": {
"REPO": "$(Repo:runtime)"
},
"dockerfile": "src/aspnet/8.0/nanoserver-1809/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-1809",
"tags": {
"$(dotnet|8.0|product-version)-nanoserver-1809": {},
"8.0-preview-nanoserver-1809": {}
}
},
{
"buildArgs": {
"REPO": "$(Repo:runtime)"
},
"dockerfile": "src/aspnet/8.0/nanoserver-ltsc2022/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-ltsc2022",
"tags": {
"$(dotnet|8.0|product-version)-nanoserver-ltsc2022": {},
"8.0-preview-nanoserver-ltsc2022": {}
}
}
]
},
Expand Down Expand Up @@ -4197,6 +4181,42 @@
}
]
},
{
"productVersion": "$(dotnet|8.0|product-version)",
"platforms": [
{
"buildArgs": {
"REPO": "$(Repo:runtime)"
},
"dockerfile": "src/aspnet/8.0/nanoserver-1809/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-1809",
"tags": {
"$(dotnet|8.0|product-version)-nanoserver-1809": {},
"8.0-preview-nanoserver-1809": {}
}
}
]
},
{
"productVersion": "$(dotnet|8.0|product-version)",
"platforms": [
{
"buildArgs": {
"REPO": "$(Repo:runtime)"
},
"dockerfile": "src/aspnet/8.0/nanoserver-ltsc2022/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-ltsc2022",
"tags": {
"$(dotnet|8.0|product-version)-nanoserver-ltsc2022": {},
"8.0-preview-nanoserver-ltsc2022": {}
}
}
]
},
{
"productVersion": "$(dotnet|8.0|product-version)",
"platforms": [
Expand Down Expand Up @@ -5030,32 +5050,6 @@
"8.0-preview-bookworm-slim-arm64v8": {}
},
"variant": "v8"
},
{
"buildArgs": {
"REPO": "$(Repo:aspnet)"
},
"dockerfile": "src/sdk/8.0/nanoserver-1809/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/sdk/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-1809",
"tags": {
"$(sdk|8.0|product-version)-nanoserver-1809": {},
"8.0-preview-nanoserver-1809": {}
}
},
{
"buildArgs": {
"REPO": "$(Repo:aspnet)"
},
"dockerfile": "src/sdk/8.0/nanoserver-ltsc2022/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/sdk/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-ltsc2022",
"tags": {
"$(sdk|8.0|product-version)-nanoserver-ltsc2022": {},
"8.0-preview-nanoserver-ltsc2022": {}
}
}
]
},
Expand Down Expand Up @@ -5269,6 +5263,42 @@
}
]
},
{
"productVersion": "$(sdk|8.0|product-version)",
"platforms": [
{
"buildArgs": {
"REPO": "$(Repo:aspnet)"
},
"dockerfile": "src/sdk/8.0/nanoserver-1809/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/sdk/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-1809",
"tags": {
"$(sdk|8.0|product-version)-nanoserver-1809": {},
"8.0-preview-nanoserver-1809": {}
}
}
]
},
{
"productVersion": "$(sdk|8.0|product-version)",
"platforms": [
{
"buildArgs": {
"REPO": "$(Repo:aspnet)"
},
"dockerfile": "src/sdk/8.0/nanoserver-ltsc2022/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/sdk/Dockerfile.windows",
"os": "windows",
"osVersion": "nanoserver-ltsc2022",
"tags": {
"$(sdk|8.0|product-version)-nanoserver-ltsc2022": {},
"8.0-preview-nanoserver-ltsc2022": {}
}
}
]
},
{
"productVersion": "$(sdk|8.0|product-version)",
"platforms": [
Expand Down