Introduce HostName to EnvironmentInfo. #4550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaliyaudagedara
requested review from
MichaelSimons,
mthalman and
lbussell
as code owners
Remove unused variable.
mthalman
reviewed
Apr 10, 2023
There was a problem hiding this comment.
Seems a reasonable addition. In this case, I think equivalent changes should be made to the console-app based sample at https://github.com/dotnet/dotnet-docker/tree/main/samples/dotnetapp
|
I am sorry for the delay. Thanks. Yes, when running in K8s, it's going to be useful to know the HostName for demo purposes. Didn't think it will be useful to have HostName in the console app. Updated. |
|
@richlander - Any input on these changes? Do you agree to have it in the console app as well or just the web app? |
|
@richlander, appreciate if you can have a look at this, thanks! |
richlander
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce HostName to EnvironmentInfo.
Remove unused variable.