Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu Chiseled "extra" images for .NET 6.0 and 7.0 #5042

Merged

Conversation

garrettsutula
Copy link
Contributor

Adds Ubuntu Chiseled "extra" images for .NET 6.0

  • ❓How do I run Validate-ImageSize.ps1 in a way where it will create a new baseline for the new image (right now retries with backoff for ones that don't exist yet).
  • ❓Are my additions to tests/Microsoft.DotNet.Docker.Tests/TestData.cs correct?

@lbussell
Copy link
Contributor

lbussell commented Dec 7, 2023

[Triage] Hi @garrettsutula, thanks for your contribution. We've heard the request for extra images for 6.0 and 7.0, so we'll gladly take your contribution. I'll push some updates to this PR soon.

Out of curiosity, what is preventing you from moving to .NET 8 and adopting Ubuntu Chiseled at the same time?

@lbussell
Copy link
Contributor

lbussell commented Dec 7, 2023

Relevant issue: #5021

@garrettsutula
Copy link
Contributor Author

garrettsutula commented Dec 7, 2023

@dotnet-policy-service agree

@lbussell thanks for the consideration! Really just that it would be nice to apply the Chiseled image now whereever possible & that can be done separate from project dependency updates.

@lbussell lbussell force-pushed the feature/add-aspnet-60-chiseled-extra branch from 15056b1 to 3af35eb Compare December 18, 2023 22:18
@lbussell lbussell changed the title Add 6.0 Ubuntu Chiseled "extra" images for .NET 6.0 Add Ubuntu Chiseled "extra" images for .NET 6.0 and 7.0 Dec 18, 2023
@lbussell lbussell merged commit 8da2b12 into dotnet:nightly Jan 2, 2024
114 checks passed
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Jan 4, 2024
Co-authored-by: Logan Bussell false <loganbussell@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants