Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write ASP.NET Core HTTPS documentation #6117

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lbussell
Copy link
Contributor

Fixes #5113

While working on #5113 I noticed that the two documents, run-aspnetcore-https-development.md and host-aspnetcore-https.md contained much of the same information. I tried to combine them and improve both documents in the process.

A couple of other notes:

  • I couldn't get Kestrel:Certificates:Development:Password or ASPNETCORE_Kestrel__Certificates__Development__Password to work for any scenario. Only Default worked.
  • I couldn't get any sample image to read a certificate from /home/app/.aspnet/https/aspnetapp.pfx, so I made all the example commands specific the exact path to the certificate. I think this is clearer anyways.

@richlander
Copy link
Member

These docs pre-date the official docs: https://learn.microsoft.com/aspnet/core/security/enforcing-ssl

Ideally, we'd rely as much as possible on the official docs. Either way, we should get the ASP.NET Core team to sign off on the changes.

@javiercn @Rick-Anderson

@lbussell
Copy link
Contributor Author

These docs pre-date the official docs: https://learn.microsoft.com/aspnet/core/security/enforcing-ssl

Ideally, we'd rely as much as possible on the official docs. Either way, we should get the ASP.NET Core team to sign off on the changes.

@javiercn @Rick-Anderson

Yes, I did find those, and they seemed very similar to these docs. Worth noting that Hosting ASP.NET Core images with Docker over HTTPS links to run-aspnetcore-https-development.md at the bottom of the document.

I would love to throw out host-aspnetcore-https.md and link to the learn.microsoft.com documentation. Not sure how others feel about that.

@richlander
Copy link
Member

I'm fine with removing old documents that we consider no longer needed.

@mthalman
Copy link
Member

I'm fine with getting rid of these files and updating the existing links to them to point to the docs site instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some sample commands still assume the in-container user will be root
3 participants