Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor registration to artifact operation #3960

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

wiktork
Copy link
Member

@wiktork wiktork commented Mar 15, 2023

Summary

Addresses #3916.

Release Notes Entry

Fixes issue where trace operations with an egress provider and rundown on Linux would cause dotnet-monitor to lose connectivity with the target application.

@wiktork wiktork requested a review from a team as a code owner March 15, 2023 17:00
@schmittjoseph
Copy link
Member

Since this is a bug fix, mind adding the update-release-notes tag and a Release Notes Entry in the PR description?

@wiktork wiktork added the update-release-notes Pull requests that should be mentioned in the release notes label Mar 15, 2023
Copy link
Member

@jander-msft jander-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this has each of the operations register themselves with the tracker regardless of listen vs connect mode, but I think that should be fine.

@jander-msft jander-msft added the servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) label Mar 15, 2023
@wiktork
Copy link
Member Author

wiktork commented Mar 15, 2023

FYI, this has each of the operations register themselves with the tracker regardless of listen vs connect mode, but I think that should be fine.

That's a good point, but I'm actually going to leave this for now. If we bridge more of the capabilities between connect and reverse modes, this may end up being useful.

@wiktork wiktork merged commit e3016ef into dotnet:release/7.x Mar 15, 2023
@wiktork
Copy link
Member Author

wiktork commented Mar 15, 2023

/backport to main

@github-actions
Copy link
Contributor

@schmittjoseph
Copy link
Member

/backport to release/7.1

@github-actions
Copy link
Contributor

Started backporting to release/7.1: https://github.com/dotnet/dotnet-monitor/actions/runs/4578084019

@github-actions
Copy link
Contributor

@schmittjoseph an error occurred while backporting to release/7.1, please check the run log for details!

Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between release/7.1 and backport/pr-3960-to-release/7.1"}

@jander-msft jander-msft removed the servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-release-notes Pull requests that should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants