Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.3] PMC define web startup project directory #1333

Merged
merged 2 commits into from
Oct 4, 2019
Merged

[release/6.3] PMC define web startup project directory #1333

merged 2 commits into from
Oct 4, 2019

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Oct 3, 2019

Fixes #1290

cc @Pilchie

@bricelam bricelam added this to the 6.3.2 milestone Oct 3, 2019
@bricelam

This comment has been minimized.

Sign in to view
@bricelam bricelam changed the base branch from release/6.4 to release/6.3 October 3, 2019 17:51
@Pilchie
Copy link
Member

Pilchie commented Oct 3, 2019

Go ahead and merge when CI passes.

@bricelam
Copy link
Contributor Author

bricelam commented Oct 3, 2019 •
edited
Loading

@AndriySvyryd Did we do anything on this repo to fix this CI issue?

Unable to open the physical file "F:\workspace.7_work\1\s\bin\AnyCPU.Debug-netcoreapp3_0\Microsoft.ML.Tests\netcoreapp3.0\TestDatabases\iris.mdf". Operating system error 3: "3(The system cannot find the path specified.)".
File activation failure. The physical file name "F:\workspace.7_work\1\s\bin\AnyCPU.Debug-netcoreapp3_0\Microsoft.ML.Tests\netcoreapp3.0\TestDatabases\iris_log.ldf" may be incorrect.

...we might need to cherry-pick it into release/6.3

@AndriySvyryd
Copy link
Member

@bricelam You can go ahead and cherry-pick ea8ded0
I'm going on vacation and won't be able to do it today

@bricelam bricelam merged commit 08d2995 into dotnet:release/6.3 Oct 4, 2019
@bricelam bricelam deleted the patch2 branch October 4, 2019 03:49
@ajcvickers ajcvickers removed this from the 6.3.1 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bricelam @Pilchie @AndriySvyryd @ajcvickers @Psypher9