Fix for #1217 #1426
Merged
Fix for #1217 #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be merged as soon as #430 is merged in again... |
Closed
|
Thanks for the contribution! |
|
@ajcvickers This will be part of preview3 or is it already included in preview2? |
|
@chrfin Preview 3. Unfortunately it takes a long time from branching to release for previews, so they don't have a lot of the more recent fixes. |
|
Ok, thanks for the info :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should fix #1217
I am aware that
GetOrAddis not thread-safe, but according to the list under remarks at https://docs.microsoft.com/en-us/dotnet/api/system.collections.concurrent.concurrentdictionary-2.getoradd it should not cause any problems in this case.