API review updates (#25450)

Part of #24743

- Add params to ContextParameterBinding and related
- Remove RelationalConnection.DbConnectionState
- Move commandSource constructor parameters to the end in *EventData classes and IRelationalCommandDiagnosticsLogger

src/EFCore.Relational/Diagnostics/CommandCorrelatedEventData.cs

@@ -62,7 +62,7 @@ public CommandCorrelatedEventData(
         /// <param name="connectionId"> A correlation ID that identifies the <see cref="DbConnection" /> instance being used. </param>
         /// <param name="async"> Indicates whether or not the command was executed asynchronously. </param>
         /// <param name="startTime"> The start time of this event. </param>
-        /// <param name="commandSource">Source of the command.</param>
+        /// <param name="commandSource"> Source of the command. </param>
         public CommandCorrelatedEventData(
             EventDefinitionBase eventDefinition,
             Func<EventDefinitionBase, EventData, string> messageGenerator,

src/EFCore.Relational/Diagnostics/CommandEndEventData.cs

@@ -70,8 +70,8 @@ public CommandEndEventData(
         /// <param name="async"> Indicates whether or not the command was executed asynchronously. </param>
         /// <param name="logParameterValues"> Indicates whether or not the application allows logging of parameter values. </param>
         /// <param name="startTime"> The start time of this event. </param>
-        /// <param name="commandSource">Source of the command.</param>
         /// <param name="duration"> The duration this event. </param>
+        /// <param name="commandSource"> Source of the command. </param>
         public CommandEndEventData(
             EventDefinitionBase eventDefinition,
             Func<EventDefinitionBase, EventData, string> messageGenerator,
@@ -84,8 +84,8 @@ public CommandEndEventData(
             bool async,
             bool logParameterValues,
             DateTimeOffset startTime,
-            CommandSource commandSource,
-            TimeSpan duration)
+            TimeSpan duration,
+            CommandSource commandSource)
             : base(
                 eventDefinition,
                 messageGenerator,

src/EFCore.Relational/Diagnostics/CommandErrorEventData.cs

@@ -75,8 +75,8 @@ public CommandErrorEventData(
         /// <param name="async"> Indicates whether or not the command was executed asynchronously. </param>
         /// <param name="logParameterValues"> Indicates whether or not the application allows logging of parameter values. </param>
         /// <param name="startTime"> The start time of this event. </param>
-        /// <param name="commandSource">Source of the command.</param>
         /// <param name="duration"> The duration this event. </param>
+        /// <param name="commandSource"> Source of the command. </param>
         public CommandErrorEventData(
             EventDefinitionBase eventDefinition,
             Func<EventDefinitionBase, EventData, string> messageGenerator,
@@ -90,8 +90,8 @@ public CommandErrorEventData(
             bool async,
             bool logParameterValues,
             DateTimeOffset startTime,
-            CommandSource commandSource,
-            TimeSpan duration)
+            TimeSpan duration,
+            CommandSource commandSource)
             : base(
                 eventDefinition,
                 messageGenerator,
@@ -104,8 +104,8 @@ public CommandErrorEventData(
                 async,
                 logParameterValues,
                 startTime,
-                commandSource,
-                duration)
+                duration,
+                commandSource)
         {
             Exception = exception;
         }

src/EFCore.Relational/Diagnostics/CommandEventData.cs

@@ -70,7 +70,7 @@ public CommandEventData(
         /// <param name="async"> Indicates whether or not the command was executed asynchronously. </param>
         /// <param name="logParameterValues"> Indicates whether or not the application allows logging of parameter values. </param>
         /// <param name="startTime"> The start time of this event. </param>
-        /// <param name="commandSource">Source of the command.</param>
+        /// <param name="commandSource"> Source of the command. </param>
         public CommandEventData(
             EventDefinitionBase eventDefinition,
             Func<EventDefinitionBase, EventData, string> messageGenerator,

src/EFCore.Relational/Diagnostics/CommandExecutedEventData.cs

@@ -73,8 +73,8 @@ public CommandExecutedEventData(
         /// <param name="async"> Indicates whether or not the command was executed asynchronously. </param>
         /// <param name="logParameterValues"> Indicates whether or not the application allows logging of parameter values. </param>
         /// <param name="startTime"> The start time of this event. </param>
-        /// <param name="commandSource">Source of the command.</param>
         /// <param name="duration"> The duration this event. </param>
+        /// <param name="commandSource"> Source of the command. </param>
         public CommandExecutedEventData(
             EventDefinitionBase eventDefinition,
             Func<EventDefinitionBase, EventData, string> messageGenerator,
@@ -88,8 +88,8 @@ public CommandExecutedEventData(
             bool async,
             bool logParameterValues,
             DateTimeOffset startTime,
-            CommandSource commandSource,
-            TimeSpan duration)
+            TimeSpan duration,
+            CommandSource commandSource)
             : base(
                 eventDefinition,
                 messageGenerator,
@@ -102,8 +102,8 @@ public CommandExecutedEventData(
                 async,
                 logParameterValues,
                 startTime,
-                commandSource,
-                duration)
+                duration,
+                commandSource)
             => Result = result;
 
         /// <summary>