Tiny: Add InExpression argument check

dotnet · Dec 9, 2019 · 313983d · 313983d
1 parent f765b9d
commit 313983d
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/EFCore.Relational/Query/SqlExpressions/InExpression.cs b/src/EFCore.Relational/Query/SqlExpressions/InExpression.cs
@@ -48,9 +48,17 @@ protected override Expression VisitChildren(ExpressionVisitor visitor)
         public virtual InExpression Negate() => new InExpression(Item, !IsNegated, Values, Subquery, TypeMapping);
 
         public virtual InExpression Update(SqlExpression item, SqlExpression values, SelectExpression subquery)
-            => item != Item || subquery != Subquery || values != Values
+        {
+            if (values != null
+                && subquery != null)
+            {
+                throw new ArgumentException($"Either {nameof(values)} or {nameof(subquery)} must be null");
+            }
+
+            return item != Item || subquery != Subquery || values != Values
                 ? new InExpression(item, IsNegated, values, subquery, TypeMapping)
                 : this;
+        }
 
         public override void Print(ExpressionPrinter expressionPrinter)
         {