Add Migration name check

Add a check during the Validate method of MigrationsAddCommand to throw a CommandException when someone tries to call their migration "migration".

Fixes #23222

src/EFCore.Design/Migrations/Design/MigrationsScaffolder.cs

@@ -81,6 +81,16 @@ public virtual ScaffoldedMigration ScaffoldMigration(
  subNamespace = "Migrations";
  }
 
+ if (string.Equals(migrationName, "migration", StringComparison.OrdinalIgnoreCase))
+ {
+ throw new OperationException(DesignStrings.CircularBaseClassDependency);
+ }
+
+ if (Dependencies.MigrationsAssembly.FindMigrationId(migrationName) != null)
+ {
+ throw new OperationException(DesignStrings.DuplicateMigrationName(migrationName));
+ }
+
  var (key, typeInfo) = Dependencies.MigrationsAssembly.Migrations.LastOrDefault();
 
  var migrationNamespace =

src/EFCore.Design/Properties/DesignStrings.resx

@@ -138,6 +138,9 @@
  <data name="CannotGenerateTypeQualifiedMethodCall" xml:space="preserve">
  <value>A type-qualified method call requires an instance identifier, a MethodInfo and no chained calls.</value>
  </data>
+ <data name="CircularBaseClassDependency" xml:space="preserve">
+ <value>You cannot add a migration with the name 'Migration'.</value>
+ </data>
  <data name="CompiledModelConstructorBinding" xml:space="preserve">
  <value>The entity type '{entityType}' has a custom constructor binding. This is usually caused by using proxies. Compiled model can't be generated, because dynamic proxy types are not supported. If you are not using proxies configure the custom constructor binding in '{customize}' in a partial '{className}' class instead.</value>
  </data>

src/ef/Commands/MigrationsAddCommand.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System;
 using System.Collections;
 using Microsoft.EntityFrameworkCore.Tools.Properties;