Revert some uses of targeted new.

dotnet · Sep 9, 2022 · 5508ac5 · 5508ac5
1 parent 000ce7f
commit 5508ac5
Show file tree

Hide file tree

Showing 364 changed files with 1,420 additions and 1,390 deletions.
diff --git a/All.sln.DotSettings b/All.sln.DotSettings
@@ -17,7 +17,7 @@
 
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeModifiersOrder/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeNamespaceBody/@EntryIndexedValue">SUGGESTION</s:String>
-	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeObjectCreationWhenTypeEvident/@EntryIndexedValue">HINT</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeObjectCreationWhenTypeEvident/@EntryIndexedValue">SUGGESTION</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeRedundantParentheses/@EntryIndexedValue">HINT</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeTypeMemberModifiers/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeTypeModifiers/@EntryIndexedValue">WARNING</s:String>
@@ -111,7 +111,7 @@
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/BRACES_FOR_FOREACH/@EntryValue">Required</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/BRACES_FOR_IFELSE/@EntryValue">Required</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/BRACES_FOR_WHILE/@EntryValue">Required</s:String>
-	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/OBJECT_CREATION_WHEN_TYPE_NOT_EVIDENT/@EntryValue">TargetTyped</s:String>
+	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/OBJECT_CREATION_WHEN_TYPE_NOT_EVIDENT/@EntryValue">ExplicitlyTyped</s:String>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/ALIGN_LINQ_QUERY/@EntryValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/ALIGN_MULTILINE_ARGUMENT/@EntryValue">False</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/ALIGN_MULTILINE_ARRAY_AND_OBJECT_INITIALIZER/@EntryValue">False</s:Boolean>

diff --git a/src/EFCore.Abstractions/ChangeTracking/Internal/SortableBindingList.cs b/src/EFCore.Abstractions/ChangeTracking/Internal/SortableBindingList.cs
@@ -43,7 +43,7 @@ protected override void ApplySortCore(PropertyDescriptor prop, ListSortDirection
             _sortDirection = direction;
             _sortProperty = prop;
             _isSorted = true;
-            OnListChanged(new(ListChangedType.Reset, -1));
+            OnListChanged(new ListChangedEventArgs(ListChangedType.Reset, -1));
         }
     }
 

diff --git a/src/EFCore.Cosmos/Extensions/CosmosDbContextOptionsExtensions.cs b/src/EFCore.Cosmos/Extensions/CosmosDbContextOptionsExtensions.cs
@@ -79,7 +79,7 @@ public static DbContextOptionsBuilder UseCosmos(
 
         ((IDbContextOptionsBuilderInfrastructure)optionsBuilder).AddOrUpdateExtension(extension);
 
-        cosmosOptionsAction?.Invoke(new(optionsBuilder));
+        cosmosOptionsAction?.Invoke(new CosmosDbContextOptionsBuilder(optionsBuilder));
 
         return optionsBuilder;
     }
@@ -147,7 +147,7 @@ public static DbContextOptionsBuilder UseCosmos(
 
         ((IDbContextOptionsBuilderInfrastructure)optionsBuilder).AddOrUpdateExtension(extension);
 
-        cosmosOptionsAction?.Invoke(new(optionsBuilder));
+        cosmosOptionsAction?.Invoke(new CosmosDbContextOptionsBuilder(optionsBuilder));
 
         return optionsBuilder;
     }
@@ -208,7 +208,7 @@ public static DbContextOptionsBuilder UseCosmos(
 
         ((IDbContextOptionsBuilderInfrastructure)optionsBuilder).AddOrUpdateExtension(extension);
 
-        cosmosOptionsAction?.Invoke(new(optionsBuilder));
+        cosmosOptionsAction?.Invoke(new CosmosDbContextOptionsBuilder(optionsBuilder));
 
         return optionsBuilder;
     }

diff --git a/src/EFCore.Cosmos/Infrastructure/Internal/CosmosModelValidator.cs b/src/EFCore.Cosmos/Infrastructure/Internal/CosmosModelValidator.cs
@@ -77,7 +77,7 @@ protected virtual void ValidateSharedContainerCompatibility(
 
             if (!containers.TryGetValue(container, out var mappedTypes))
             {
-                mappedTypes = new();
+                mappedTypes = new List<IEntityType>();
                 containers[container] = mappedTypes;
             }
 

diff --git a/src/EFCore.Cosmos/Metadata/Conventions/Internal/CosmosConventionSetBuilder.cs b/src/EFCore.Cosmos/Metadata/Conventions/Internal/CosmosConventionSetBuilder.cs
@@ -59,7 +59,7 @@ public static ModelBuilder CreateModelBuilder()
     {
         using var serviceScope = CreateServiceScope();
         using var context = serviceScope.ServiceProvider.GetRequiredService<DbContext>();
-        return new(ConventionSet.CreateConventionSet(context), context.GetService<ModelDependencies>());
+        return new ModelBuilder(ConventionSet.CreateConventionSet(context), context.GetService<ModelDependencies>());
     }
 
     private static IServiceScope CreateServiceScope()

diff --git a/src/EFCore.Cosmos/Query/Internal/CollectionShaperExpression.cs b/src/EFCore.Cosmos/Query/Internal/CollectionShaperExpression.cs
@@ -112,7 +112,7 @@ public virtual CollectionShaperExpression Update(
         Check.NotNull(innerShaper, nameof(innerShaper));
 
         return projection != Projection || innerShaper != InnerShaper
-            ? new(projection, innerShaper, Navigation, ElementType)
+            ? new CollectionShaperExpression(projection, innerShaper, Navigation, ElementType)
             : this;
     }
 

diff --git a/src/EFCore.Cosmos/Query/Internal/CosmosProjectionBindingExpressionVisitor.cs b/src/EFCore.Cosmos/Query/Internal/CosmosProjectionBindingExpressionVisitor.cs
@@ -57,7 +57,7 @@ public virtual Expression Translate(SelectExpression selectExpression, Expressio
         _selectExpression = selectExpression;
         _clientEval = false;
 
-        _projectionMembers.Push(new());
+        _projectionMembers.Push(new ProjectionMember());
 
         var result = Visit(expression);
         if (result == null)

diff --git a/src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs b/src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
@@ -40,13 +40,13 @@ public CosmosQueryableMethodTranslatingExpressionVisitor(
         _sqlExpressionFactory = sqlExpressionFactory;
         _memberTranslatorProvider = memberTranslatorProvider;
         _methodCallTranslatorProvider = methodCallTranslatorProvider;
-        _sqlTranslator = new(
+        _sqlTranslator = new CosmosSqlTranslatingExpressionVisitor(
             queryCompilationContext,
             _sqlExpressionFactory,
             _memberTranslatorProvider,
             _methodCallTranslatorProvider);
         _projectionBindingExpressionVisitor =
-            new(_queryCompilationContext.Model, _sqlTranslator);
+            new CosmosProjectionBindingExpressionVisitor(_queryCompilationContext.Model, _sqlTranslator);
     }
 
     /// <summary>
@@ -61,13 +61,13 @@ protected CosmosQueryableMethodTranslatingExpressionVisitor(
     {
         _queryCompilationContext = parentVisitor._queryCompilationContext;
         _sqlExpressionFactory = parentVisitor._sqlExpressionFactory;
-        _sqlTranslator = new(
+        _sqlTranslator = new CosmosSqlTranslatingExpressionVisitor(
             QueryCompilationContext,
             _sqlExpressionFactory,
             _memberTranslatorProvider,
             _methodCallTranslatorProvider);
         _projectionBindingExpressionVisitor =
-            new(_queryCompilationContext.Model, _sqlTranslator);
+            new CosmosProjectionBindingExpressionVisitor(_queryCompilationContext.Model, _sqlTranslator);
     }
 
     /// <summary>
@@ -271,7 +271,7 @@ protected override ShapedQueryExpression TranslateAverage(ShapedQueryExpression
             source = TranslateSelect(source, selector);
         }
 
-        var projection = (SqlExpression)selectExpression.GetMappedProjection(new());
+        var projection = (SqlExpression)selectExpression.GetMappedProjection(new ProjectionMember());
         projection = _sqlExpressionFactory.Function(
             "AVG", new[] { projection }, projection.Type, projection.TypeMapping);
 
@@ -575,7 +575,7 @@ protected override ShapedQueryExpression TranslateMax(ShapedQueryExpression sour
             source = TranslateSelect(source, selector);
         }
 
-        var projection = (SqlExpression)selectExpression.GetMappedProjection(new());
+        var projection = (SqlExpression)selectExpression.GetMappedProjection(new ProjectionMember());
 
         projection = _sqlExpressionFactory.Function("MAX", new[] { projection }, resultType, projection.TypeMapping);
 
@@ -603,7 +603,7 @@ protected override ShapedQueryExpression TranslateMin(ShapedQueryExpression sour
             source = TranslateSelect(source, selector);
         }
 
-        var projection = (SqlExpression)selectExpression.GetMappedProjection(new());
+        var projection = (SqlExpression)selectExpression.GetMappedProjection(new ProjectionMember());
 
         projection = _sqlExpressionFactory.Function("MIN", new[] { projection }, resultType, projection.TypeMapping);
 
@@ -682,7 +682,7 @@ protected override ShapedQueryExpression TranslateOrderBy(
         var translation = TranslateLambdaExpression(source, keySelector);
         if (translation != null)
         {
-            ((SelectExpression)source.QueryExpression).ApplyOrdering(new(translation, ascending));
+            ((SelectExpression)source.QueryExpression).ApplyOrdering(new OrderingExpression(translation, ascending));
 
             return source;
         }
@@ -841,7 +841,7 @@ protected override ShapedQueryExpression TranslateSum(ShapedQueryExpression sour
         }
 
         var serverOutputType = resultType.UnwrapNullableType();
-        var projection = (SqlExpression)selectExpression.GetMappedProjection(new());
+        var projection = (SqlExpression)selectExpression.GetMappedProjection(new ProjectionMember());
 
         projection = _sqlExpressionFactory.Function(
             "SUM", new[] { projection }, serverOutputType, projection.TypeMapping);
@@ -895,7 +895,7 @@ protected override ShapedQueryExpression TranslateThenBy(ShapedQueryExpression s
         var translation = TranslateLambdaExpression(source, keySelector);
         if (translation != null)
         {
-            ((SelectExpression)source.QueryExpression).AppendOrdering(new(translation, ascending));
+            ((SelectExpression)source.QueryExpression).AppendOrdering(new OrderingExpression(translation, ascending));
 
             return source;
         }

diff --git a/...edQueryCompilingExpressionVisitor.CosmosProjectionBindingRemovingExpressionVisitorBase.cs b/...edQueryCompilingExpressionVisitor.CosmosProjectionBindingRemovingExpressionVisitorBase.cs
@@ -330,7 +330,7 @@ private BlockExpression AddIncludes(BlockExpression shaperBlock)
             shaperExpressions.RemoveAt(shaperExpressions.Count - 1);
 
             var includesToProcess = _pendingIncludes;
-            _pendingIncludes = new();
+            _pendingIncludes = new List<IncludeExpression>();
 
             foreach (var include in includesToProcess)
             {

diff --git a/src/EFCore.Cosmos/Query/Internal/CosmosSqlTranslatingExpressionVisitor.cs b/src/EFCore.Cosmos/Query/Internal/CosmosSqlTranslatingExpressionVisitor.cs
@@ -59,7 +59,7 @@ public CosmosSqlTranslatingExpressionVisitor(
         _sqlExpressionFactory = sqlExpressionFactory;
         _memberTranslatorProvider = memberTranslatorProvider;
         _methodCallTranslatorProvider = methodCallTranslatorProvider;
-        _sqlVerifyingExpressionVisitor = new();
+        _sqlVerifyingExpressionVisitor = new SqlTypeMappingVerifyingExpressionVisitor();
     }
 
     /// <summary>
@@ -1064,7 +1064,7 @@ public Expression Convert(Type type)
             => type == typeof(object) // Ignore object conversion
                 || type.IsAssignableFrom(Type) // Ignore conversion to base/interface
                     ? this
-                    : new(ParameterEntity, type);
+                    : new EntityReferenceExpression(ParameterEntity, type);
     }
 
     private sealed class SqlTypeMappingVerifyingExpressionVisitor : ExpressionVisitor

diff --git a/src/EFCore.Cosmos/Query/Internal/EntityProjectionExpression.cs b/src/EFCore.Cosmos/Query/Internal/EntityProjectionExpression.cs
@@ -90,7 +90,7 @@ protected override Expression VisitChildren(ExpressionVisitor visitor)
     /// </summary>
     public virtual Expression Update(Expression accessExpression)
         => accessExpression != AccessExpression
-            ? new(EntityType, accessExpression)
+            ? new EntityProjectionExpression(EntityType, accessExpression)
             : this;
 
     /// <summary>
@@ -236,7 +236,7 @@ public virtual EntityProjectionExpression UpdateEntityType(IEntityType derivedTy
                     derivedType.DisplayName(), EntityType.DisplayName()));
         }
 
-        return new(derivedType, AccessExpression);
+        return new EntityProjectionExpression(derivedType, AccessExpression);
     }
 
     /// <summary>

diff --git a/src/EFCore.Cosmos/Query/Internal/FromSqlExpression.cs b/src/EFCore.Cosmos/Query/Internal/FromSqlExpression.cs
@@ -54,7 +54,7 @@ public override string Alias
     /// </summary>
     public virtual FromSqlExpression Update(Expression arguments)
         => arguments != Arguments
-            ? new(EntityType, Alias, Sql, arguments)
+            ? new FromSqlExpression(EntityType, Alias, Sql, arguments)
             : this;
 
     /// <inheritdoc />

diff --git a/src/EFCore.Cosmos/Query/Internal/FromSqlQueryRootExpression.cs b/src/EFCore.Cosmos/Query/Internal/FromSqlQueryRootExpression.cs
@@ -92,7 +92,7 @@ protected override Expression VisitChildren(ExpressionVisitor visitor)
         var argument = visitor.Visit(Argument);
 
         return argument != Argument
-            ? new(EntityType, Sql, argument)
+            ? new FromSqlQueryRootExpression(EntityType, Sql, argument)
             : this;
     }
 

diff --git a/src/EFCore.Cosmos/Query/Internal/InExpression.cs b/src/EFCore.Cosmos/Query/Internal/InExpression.cs
@@ -84,7 +84,7 @@ public virtual InExpression Negate()
     /// </summary>
     public virtual InExpression Update(SqlExpression item, SqlExpression values)
         => item != Item || values != Values
-            ? new(item, IsNegated, values, TypeMapping!)
+            ? new InExpression(item, IsNegated, values, TypeMapping!)
             : this;
 
     /// <summary>

diff --git a/src/EFCore.Cosmos/Query/Internal/KeyAccessExpression.cs b/src/EFCore.Cosmos/Query/Internal/KeyAccessExpression.cs
@@ -70,7 +70,7 @@ protected override Expression VisitChildren(ExpressionVisitor visitor)
     /// </summary>
     public virtual KeyAccessExpression Update(Expression outerExpression)
         => outerExpression != AccessExpression
-            ? new(Property, outerExpression)
+            ? new KeyAccessExpression(Property, outerExpression)
             : this;
 
     /// <summary>

diff --git a/src/EFCore.Cosmos/Query/Internal/ObjectAccessExpression.cs b/src/EFCore.Cosmos/Query/Internal/ObjectAccessExpression.cs
@@ -94,7 +94,7 @@ protected override Expression VisitChildren(ExpressionVisitor visitor)
     /// </summary>
     public virtual ObjectAccessExpression Update(Expression outerExpression)
         => outerExpression != AccessExpression
-            ? new(Navigation, outerExpression)
+            ? new ObjectAccessExpression(Navigation, outerExpression)
             : this;
 
     /// <summary>

diff --git a/src/EFCore.Cosmos/Query/Internal/ObjectArrayProjectionExpression.cs b/src/EFCore.Cosmos/Query/Internal/ObjectArrayProjectionExpression.cs
@@ -118,7 +118,7 @@ public virtual ObjectArrayProjectionExpression Update(
         Expression accessExpression,
         EntityProjectionExpression innerProjection)
         => accessExpression != AccessExpression || innerProjection != InnerProjection
-            ? new(Navigation, accessExpression, innerProjection)
+            ? new ObjectArrayProjectionExpression(Navigation, accessExpression, innerProjection)
             : this;
 
     /// <summary>

diff --git a/src/EFCore.Cosmos/Query/Internal/OrderingExpression.cs b/src/EFCore.Cosmos/Query/Internal/OrderingExpression.cs
@@ -74,7 +74,7 @@ protected override Expression VisitChildren(ExpressionVisitor visitor)
     /// </summary>
     public virtual OrderingExpression Update(SqlExpression expression)
         => expression != Expression
-            ? new(expression, IsAscending)
+            ? new OrderingExpression(expression, IsAscending)
             : this;
 
     /// <summary>

diff --git a/src/EFCore.Cosmos/Query/Internal/ProjectionExpression.cs b/src/EFCore.Cosmos/Query/Internal/ProjectionExpression.cs
@@ -85,7 +85,7 @@ protected override Expression VisitChildren(ExpressionVisitor visitor)
     /// </summary>
     public virtual ProjectionExpression Update(Expression expression)
         => expression != Expression
-            ? new(expression, Alias)
+            ? new ProjectionExpression(expression, Alias)
             : this;
 
     /// <summary>

diff --git a/src/EFCore.Cosmos/Query/Internal/QuerySqlGenerator.cs b/src/EFCore.Cosmos/Query/Internal/QuerySqlGenerator.cs
@@ -82,12 +82,12 @@ public virtual CosmosSqlQuery GetSqlQuery(
     {
         _sqlBuilder.Clear();
         _parameterValues = parameterValues;
-        _sqlParameters = new();
-        _parameterNameGenerator = new();
+        _sqlParameters = new List<SqlParameter>();
+        _parameterNameGenerator = new ParameterNameGenerator();
 
         Visit(selectExpression);
 
-        return new(_sqlBuilder.ToString(), _sqlParameters);
+        return new CosmosSqlQuery(_sqlBuilder.ToString(), _sqlParameters);
     }
 
     /// <summary>
@@ -282,7 +282,7 @@ when _parameterValues.TryGetValue(parameterExpression.Name, out var parameterVal
                 for (var i = 0; i < parameterValues.Length; i++)
                 {
                     var parameterName = _parameterNameGenerator.GenerateNext();
-                    _sqlParameters.Add(new(parameterName, parameterValues[i]));
+                    _sqlParameters.Add(new SqlParameter(parameterName, parameterValues[i]));
                     substitutions[i] = parameterName;
                 }
 
@@ -492,7 +492,7 @@ protected override Expression VisitSqlParameter(SqlParameterExpression sqlParame
         if (_sqlParameters.All(sp => sp.Name != parameterName))
         {
             var jToken = GenerateJToken(_parameterValues[sqlParameterExpression.Name], sqlParameterExpression.TypeMapping);
-            _sqlParameters.Add(new(parameterName, jToken));
+            _sqlParameters.Add(new SqlParameter(parameterName, jToken));
         }
 
         _sqlBuilder.Append(parameterName);

diff --git a/src/EFCore.Cosmos/Query/Internal/ReadItemExpression.cs b/src/EFCore.Cosmos/Query/Internal/ReadItemExpression.cs
@@ -77,7 +77,7 @@ public ReadItemExpression(
     {
         Container = entityType.GetContainer();
 
-        ProjectionExpression = new(
+        ProjectionExpression = new ProjectionExpression(
             new EntityProjectionExpression(
                 entityType,
                 new RootReferenceExpression(entityType, RootAlias)),

diff --git a/src/EFCore.Cosmos/Query/Internal/SelectExpression.cs b/src/EFCore.Cosmos/Query/Internal/SelectExpression.cs
@@ -33,8 +33,8 @@ public class SelectExpression : Expression
     public SelectExpression(IEntityType entityType)
     {
         Container = entityType.GetContainer();
-        FromExpression = new(entityType, RootAlias);
-        _projectionMapping[new()] = new EntityProjectionExpression(entityType, FromExpression);
+        FromExpression = new RootReferenceExpression(entityType, RootAlias);
+        _projectionMapping[new ProjectionMember()] = new EntityProjectionExpression(entityType, FromExpression);
     }
 
     /// <summary>
@@ -47,7 +47,7 @@ public SelectExpression(IEntityType entityType, string sql, Expression argument)
     {
         Container = entityType.GetContainer();
         FromExpression = new FromSqlExpression(entityType, RootAlias, sql, argument);
-        _projectionMapping[new()] = new EntityProjectionExpression(
+        _projectionMapping[new ProjectionMember()] = new EntityProjectionExpression(
             entityType, new RootReferenceExpression(entityType, RootAlias));
     }
 
@@ -273,7 +273,7 @@ private int AddToProjection(Expression expression, string alias)
             currentAlias = $"{baseAlias}{counter++}";
         }
 
-        _projection.Add(new(expression, currentAlias));
+        _projection.Add(new ProjectionExpression(expression, currentAlias));
 
         return _projection.Count - 1;
     }
@@ -408,7 +408,7 @@ public virtual void ReverseOrderings()
         foreach (var existingOrdering in existingOrderings)
         {
             _orderings.Add(
-                new(
+                new OrderingExpression(
                     existingOrdering.Expression,
                     !existingOrdering.IsAscending));
         }
@@ -524,7 +524,7 @@ public virtual SelectExpression Update(
             projectionMapping[projectionMember] = expression;
         }
 
-        return new(projections, fromExpression, orderings, Container)
+        return new SelectExpression(projections, fromExpression, orderings, Container)
         {
             _projectionMapping = projectionMapping,
             Predicate = predicate,

diff --git a/src/EFCore.Cosmos/Query/Internal/SqlBinaryExpression.cs b/src/EFCore.Cosmos/Query/Internal/SqlBinaryExpression.cs
@@ -108,7 +108,7 @@ protected override Expression VisitChildren(ExpressionVisitor visitor)
     /// </summary>
     public virtual SqlBinaryExpression Update(SqlExpression left, SqlExpression right)
         => left != Left || right != Right
-            ? new(OperatorType, left, right, Type, TypeMapping)
+            ? new SqlBinaryExpression(OperatorType, left, right, Type, TypeMapping)
             : this;
 
     /// <summary>