No test left behind: Ef6GroupByTest (#26974)

dotnet · Dec 18, 2021 · 58b46ae · 58b46ae
1 parent 343233a
commit 58b46ae
Show file tree

Hide file tree

Showing 4 changed files with 712 additions and 277 deletions.
diff --git a/test/EFCore.InMemory.FunctionalTests/Query/Ef6GroupByInMemoryTest.cs b/test/EFCore.InMemory.FunctionalTests/Query/Ef6GroupByInMemoryTest.cs
@@ -18,46 +18,6 @@ group p by p.Category
                   into g
                   select new { Category = g.Key, AveragePrice = g.Average(p => p.UnitPrice) });
 
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_doesnt_produce_a_groupby_statement(bool async)
-        => await base.Grouping_by_all_columns_doesnt_produce_a_groupby_statement(async);
-
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_with_aggregate_function_works_2(bool async)
-        => await base.Grouping_by_all_columns_with_aggregate_function_works_2(async);
-
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_with_aggregate_function_works_3(bool async)
-        => await base.Grouping_by_all_columns_with_aggregate_function_works_3(async);
-
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_with_aggregate_function_works_4(bool async)
-        => await base.Grouping_by_all_columns_with_aggregate_function_works_4(async);
-
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_with_aggregate_function_works_5(bool async)
-        => await base.Grouping_by_all_columns_with_aggregate_function_works_5(async);
-
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_with_aggregate_function_works_6(bool async)
-        => await base.Grouping_by_all_columns_with_aggregate_function_works_6(async);
-
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_with_aggregate_function_works_7(bool async)
-        => await base.Grouping_by_all_columns_with_aggregate_function_works_7(async);
-
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_with_aggregate_function_works_8(bool async)
-        => await base.Grouping_by_all_columns_with_aggregate_function_works_8(async);
-
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_with_aggregate_function_works_9(bool async)
-        => await base.Grouping_by_all_columns_with_aggregate_function_works_9(async);
-
-    [ConditionalTheory(Skip = "Issue #17653")]
-    public override async Task Grouping_by_all_columns_with_aggregate_function_works_10(bool async)
-        => await base.Grouping_by_all_columns_with_aggregate_function_works_10(async);
-
     public class Ef6GroupByInMemoryFixture : Ef6GroupByFixtureBase
     {
         protected override ITestStoreFactory TestStoreFactory