Fix DiagnosticListener memory leak

When IsConfigured is called, it applies all services. This caused a DiagnosticListener to get instantiated on each DbContext instantiation, and since it wasn't disposed it caused a leak. Fixes #15173
dotnet · Jun 12, 2019 · 5fc73a3 · 5fc73a3
1 parent 073ca25
commit 5fc73a3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/EFCore/Infrastructure/EntityFrameworkServicesBuilder.cs b/src/EFCore/Infrastructure/EntityFrameworkServicesBuilder.cs
@@ -266,7 +266,7 @@ public virtual EntityFrameworkServicesBuilder TryAddCoreServices()
             TryAdd<IShapedQueryOptimizerFactory, ShapedQueryOptimizerFactory>();
 
             ServiceCollectionMap
-                .TryAddSingleton<DiagnosticSource>(new DiagnosticListener(DbLoggerCategory.Name));
+                .TryAddSingleton<DiagnosticSource>(p => new DiagnosticListener(DbLoggerCategory.Name));
 
             ServiceCollectionMap.GetInfrastructure()
                 .AddDependencySingleton<LazyLoaderParameterBindingFactoryDependencies>()