Obsolete CoreTypeMapping.ValueGeneratorFactory

src/EFCore.Relational/Metadata/Internal/CheckConstraint.cs

@@ -423,7 +423,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((ICheckConstraint)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoreStoredProcedure.cs

@@ -171,7 +171,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoreStoredProcedure)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoreStoredProcedureParameter.cs

@@ -84,7 +84,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoreStoredProcedureParameter)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoreStoredProcedureResultColumn.cs

@@ -72,7 +72,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoreStoredProcedureResultColumn)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoreStoredProcedureReturnValue.cs

@@ -61,7 +61,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoreStoredProcedureReturnValue)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoredProcedure.cs

@@ -690,7 +690,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoredProcedure)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoredProcedureMapping.cs

@@ -86,7 +86,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoredProcedureMapping)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoredProcedureParameter.cs

@@ -266,7 +266,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoredProcedureParameter)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoredProcedureParameterMapping.cs

@@ -68,7 +68,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoredProcedureParameterMapping)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoredProcedureResultColumn.cs

@@ -184,7 +184,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoredProcedureResultColumn)this).ToDebugString(),

src/EFCore.Relational/Metadata/Internal/StoredProcedureResultColumnMapping.cs

@@ -68,7 +68,6 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IStoredProcedureResultColumnMapping)this).ToDebugString(),

src/EFCore.Relational/Storage/ValueConversion/RelationalConverterMappingHints.cs

@@ -30,7 +30,7 @@ public RelationalConverterMappingHints(
         int? scale = null,
         bool? unicode = null,
         bool? fixedLength = null,
-        Func<IProperty, ITypeBase, ValueGenerator>? valueGeneratorFactory = null,
+        Func<IProperty, IEntityType, ValueGenerator>? valueGeneratorFactory = null,
         DbType? dbType = null)
         : base(size, precision, scale, unicode, valueGeneratorFactory)
     {
@@ -71,7 +71,9 @@ public override ConverterMappingHints With(ConverterMappingHints? hints)
                 hints.Scale ?? Scale,
                 hints.IsUnicode ?? IsUnicode,
                 (hints as RelationalConverterMappingHints)?.IsFixedLength ?? IsFixedLength,
+#pragma warning disable CS0612 // Type or member is obsolete
                 hints.ValueGeneratorFactory ?? ValueGeneratorFactory,
+#pragma warning restore CS0612 // Type or member is obsolete
                 (hints as RelationalConverterMappingHints)?.DbType ?? DbType);
 
     /// <inheritdoc />
@@ -84,7 +86,9 @@ public override ConverterMappingHints Override(ConverterMappingHints? hints)
                 Scale ?? hints.Scale,
                 IsUnicode ?? hints.IsUnicode,
                 IsFixedLength ?? (hints as RelationalConverterMappingHints)?.IsFixedLength,
+#pragma warning disable CS0612 // Type or member is obsolete
                 ValueGeneratorFactory ?? hints.ValueGeneratorFactory,
+#pragma warning restore CS0612 // Type or member is obsolete
                 DbType ?? (hints as RelationalConverterMappingHints)?.DbType);
 
     /// <summary>

src/EFCore/Metadata/RuntimeSkipNavigation.cs

@@ -115,6 +115,7 @@ public override string ToString()
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
+    [EntityFrameworkInternal]
     public virtual DebugView DebugView
         => new(
             () => ((IReadOnlySkipNavigation)this).ToDebugString(),

src/EFCore/Storage/CoreTypeMapping.cs

@@ -213,8 +213,10 @@ protected CoreTypeMapping(CoreTypeMappingParameters parameters)
             _providerValueComparer = parameters.ProviderValueComparer;
         }
 
+#pragma warning disable CS0612 // Type or member is obsolete
         ValueGeneratorFactory = parameters.ValueGeneratorFactory
             ?? converter?.MappingHints?.ValueGeneratorFactory;
+#pragma warning restore CS0612 // Type or member is obsolete
     }
 
     /// <summary>
@@ -242,7 +244,8 @@ public virtual ValueConverter? Converter
     ///     An optional factory for creating a specific <see cref="ValueGenerator" /> to use with
     ///     this mapping.
     /// </summary>
-    public virtual Func<IProperty, ITypeBase, ValueGenerator>? ValueGeneratorFactory { get; }
+    [Obsolete]
+    public virtual Func<IProperty, IEntityType, ValueGenerator>? ValueGeneratorFactory { get; }
 
     /// <summary>
     ///     A <see cref="ValueComparer" /> adds custom value snapshotting and comparison for

src/EFCore/Storage/ValueConversion/ConverterMappingHints.cs

@@ -28,13 +28,15 @@ public ConverterMappingHints(
         int? precision = null,
         int? scale = null,
         bool? unicode = null,
-        Func<IProperty, ITypeBase, ValueGenerator>? valueGeneratorFactory = null)
+        Func<IProperty, IEntityType, ValueGenerator>? valueGeneratorFactory = null)
     {
         Size = size;
         Precision = precision;
         Scale = scale;
         IsUnicode = unicode;
+#pragma warning disable CS0612 // Type or member is obsolete
         ValueGeneratorFactory = valueGeneratorFactory;
+#pragma warning restore CS0612 // Type or member is obsolete
     }
 
     /// <summary>
@@ -54,7 +56,9 @@ public virtual ConverterMappingHints With(ConverterMappingHints? hints)
                     hints.Precision ?? Precision,
                     hints.Scale ?? Scale,
                     hints.IsUnicode ?? IsUnicode,
+#pragma warning disable CS0612 // Type or member is obsolete
                     hints.ValueGeneratorFactory ?? ValueGeneratorFactory)
+#pragma warning restore CS0612 // Type or member is obsolete
                 : hints.Override(this);
 
     /// <summary>
@@ -74,7 +78,9 @@ public virtual ConverterMappingHints Override(ConverterMappingHints? hints)
                     Precision ?? hints.Precision,
                     Scale ?? hints.Scale,
                     IsUnicode ?? hints.IsUnicode,
+#pragma warning disable CS0612 // Type or member is obsolete
                     ValueGeneratorFactory ?? hints.ValueGeneratorFactory)
+#pragma warning restore CS0612 // Type or member is obsolete
                 : hints.With(this);
 
     /// <summary>
@@ -101,5 +107,6 @@ public virtual ConverterMappingHints Override(ConverterMappingHints? hints)
     ///     An optional factory for creating a specific <see cref="ValueGenerator" /> to use for model
     ///     values when this converter is being used.
     /// </summary>
-    public virtual Func<IProperty, ITypeBase, ValueGenerator>? ValueGeneratorFactory { get; }
+    [Obsolete]
+    public virtual Func<IProperty, IEntityType, ValueGenerator>? ValueGeneratorFactory { get; }
 }

src/EFCore/ValueGeneration/ValueGeneratorSelector.cs

@@ -58,16 +58,22 @@ public ValueGeneratorSelector(ValueGeneratorSelectorDependencies dependencies)
     public virtual ValueGenerator Select(IProperty property, ITypeBase typeBase)
         => Cache.GetOrAdd(property, typeBase, (p, t) => CreateFromFactory(p, t) ?? Create(p, t));
 
-    private static ValueGenerator? CreateFromFactory(IProperty property, ITypeBase entityType)
+    private static ValueGenerator? CreateFromFactory(IProperty property, ITypeBase structuralType)
     {
         var factory = property.GetValueGeneratorFactory();
         if (factory == null)
         {
             var mapping = property.GetTypeMapping();
-            factory = mapping.ValueGeneratorFactory;
+#pragma warning disable CS0612 // Type or member is obsolete
+            if (mapping.ValueGeneratorFactory != null
+                && structuralType is IEntityType)
+            {
+                factory = (p, t) => mapping.ValueGeneratorFactory.Invoke(p, (IEntityType)t);
+            }
+#pragma warning restore CS0612 // Type or member is obsolete
         }
 
-        return factory?.Invoke(property, entityType);
+        return factory?.Invoke(property, structuralType);
     }
 
     /// <summary>