Skip to content

Commit

Permalink
React to PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@AndriySvyryd
AndriySvyryd committed Aug 16, 2021
1 parent e250649 commit a3a06cf
Show file tree
Hide file tree
Showing 3 changed files with 77 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/EFCore.Cosmos/Query/Internal/InExpression.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public InExpression(
SqlExpression item,
bool negated,
SqlExpression values,
CoreTypeMapping? typeMapping)
CoreTypeMapping typeMapping)
: base(typeof(bool), typeMapping)
{
Item = item;
Expand Down
4 changes: 2 additions & 2 deletions src/EFCore.Relational/Query/SqlExpressions/InExpression.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public InExpression(
SqlExpression item,
SelectExpression subquery,
bool negated,
RelationalTypeMapping? typeMapping)
RelationalTypeMapping typeMapping)
: this(Check.NotNull(item, nameof(item)), null, Check.NotNull(subquery, nameof(subquery)), negated, typeMapping)
{
}
Expand All @@ -82,7 +82,7 @@ public InExpression(
SqlExpression item,
SqlExpression values,
bool negated,
RelationalTypeMapping? typeMapping)
RelationalTypeMapping typeMapping)
: this(Check.NotNull(item, nameof(item)), Check.NotNull(values, nameof(values)), null, negated, typeMapping)
{
}
Expand Down
82 changes: 74 additions & 8 deletions src/EFCore/ModelConfigurationBuilder.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,12 @@ public virtual ModelConfigurationBuilder IgnoreAny(Type type)
}

/// <summary>
/// Marks the given and derived types as corresponding to entity type properties.
/// <para>
/// Marks the given and derived types as corresponding to entity type properties.
/// </para>
/// <para>
/// This can also be called on an interface to apply the configuration to all properties of implementing types.
/// </para>
/// </summary>
/// <typeparam name="TProperty"> The property type to be configured. </typeparam>
/// <returns> An object that can be used to configure the properties. </returns>
Expand All @@ -86,7 +91,12 @@ public virtual PropertiesConfigurationBuilder<TProperty> Properties<TProperty>()
}

/// <summary>
/// Marks the given and derived types as corresponding to entity type properties.
/// <para>
/// Marks the given and derived types as corresponding to entity type properties.
/// </para>
/// <para>
/// This can also be called on an interface to apply the configuration to all properties of implementing types.
/// </para>
/// </summary>
/// <typeparam name="TProperty"> The property type to be configured. </typeparam>
/// <param name="buildAction"> An action that performs configuration of the property. </param>
Expand All @@ -105,7 +115,13 @@ public virtual ModelConfigurationBuilder Properties<TProperty>(
}

/// <summary>
/// Marks the given and derived types as corresponding to entity type properties.
/// <para>
/// Marks the given and derived types as corresponding to entity type properties.
/// </para>
/// <para>
/// This can also be called on an interface or an unbound generic type to apply the configuration to all
/// properties of implementing and constructed types.
/// </para>
/// </summary>
/// <param name="propertyType"> The property type to be configured. </param>
/// <returns> An object that can be used to configure the property. </returns>
Expand All @@ -119,7 +135,13 @@ public virtual PropertiesConfigurationBuilder Properties(Type propertyType)
}

/// <summary>
/// Marks the given and derived types as corresponding to entity type properties.
/// <para>
/// Marks the given and derived types as corresponding to entity type properties.
/// </para>
/// <para>
/// This can also be called on an interface or an unbound generic type to apply the configuration to all
/// properties of implementing and constructed types.
/// </para>
/// </summary>
/// <param name="propertyType"> The property type to be configured. </param>
/// <param name="buildAction"> An action that performs configuration of the property. </param>
Expand All @@ -140,7 +162,18 @@ public virtual ModelConfigurationBuilder Properties(
}

/// <summary>
/// Marks the given type as a scalar, even when used outside of entity types.
/// <para>
/// Marks the given type as a scalar, even when used outside of entity types. This allows values of this type
/// to be used in queries that are not referencing property of this type.
/// </para>
/// <para>
/// Unlike <see cref="Properties{TProperty}()"/> this method should only be called on a non-nullable concrete type.
/// Calling it on a base type will not apply the configuration to the derived types.
/// </para>
/// <para>
/// Calling this is rarely needed. If there are properties of the given type calling <see cref="Properties{TProperty}()"/>
/// should be enough in most cases.
/// </para>
/// </summary>
/// <typeparam name="TScalar"> The scalar type to be configured. </typeparam>
/// <returns> An object that can be used to configure the scalars. </returns>
Expand All @@ -152,7 +185,18 @@ public virtual ScalarConfigurationBuilder<TScalar> Scalars<TScalar>()
}

/// <summary>
/// Marks the given type as a scalar, even when used outside of entity types.
/// <para>
/// Marks the given type as a scalar, even when used outside of entity types. This allows values of this type
/// to be used in queries that are not referencing property of this type.
/// </para>
/// <para>
/// Unlike <see cref="Properties{TProperty}()"/> this method should only be called on a non-nullable concrete type.
/// Calling it on a base type will not apply the configuration to the derived types.
/// </para>
/// <para>
/// Calling this is rarely needed. If there are properties of the given type calling <see cref="Properties{TProperty}()"/>
/// should be enough in most cases.
/// </para>
/// </summary>
/// <typeparam name="TScalar"> The scalar type to be configured. </typeparam>
/// <param name="buildAction"> An action that performs configuration for the scalars. </param>
Expand All @@ -171,7 +215,18 @@ public virtual ModelConfigurationBuilder Scalars<TScalar>(
}

/// <summary>
/// Marks the given type as a scalar, even when used outside of entity types.
/// <para>
/// Marks the given type as a scalar, even when used outside of entity types. This allows values of this type
/// to be used in queries that are not referencing property of this type.
/// </para>
/// <para>
/// Unlike <see cref="Properties(Type)"/> this method should only be called on a non-nullable concrete type.
/// Calling it on a base type will not apply the configuration to the derived types.
/// </para>
/// <para>
/// Calling this is rarely needed. If there are properties of the given type calling <see cref="Properties(Type)"/>
/// should be enough in most cases.
/// </para>
/// </summary>
/// <param name="scalarType"> The scalar type to be configured. </param>
/// <returns> An object that can be used to configure the scalars. </returns>
Expand All @@ -185,7 +240,18 @@ public virtual ScalarConfigurationBuilder Scalars(Type scalarType)
}

/// <summary>
/// Marks the given type as a scalar, even when used outside of entity types.
/// <para>
/// Marks the given type as a scalar, even when used outside of entity types. This allows values of this type
/// to be used in queries that are not referencing property of this type.
/// </para>
/// <para>
/// Unlike <see cref="Properties(Type)"/> this method should only be called on a non-nullable concrete type.
/// Calling it on a base type will not apply the configuration to the derived types.
/// </para>
/// <para>
/// Calling this is rarely needed. If there are properties of the given type calling <see cref="Properties(Type)"/>
/// should be enough in most cases.
/// </para>
/// </summary>
/// <param name="scalarType"> The scalar type to be configured. </param>
/// <param name="buildAction"> An action that performs configuration for the scalars. </param>
Expand Down

0 comments on commit a3a06cf

Please sign in to comment.