Query: Add TPC test bases

These only adds disabled test classes

Part of #3170

test/EFCore.Relational.Specification.Tests/Query/TPCFiltersInheritanceQueryTestBase.cs

@@ -0,0 +1,15 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+// ReSharper disable InconsistentNaming
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCFiltersInheritanceQueryTestBase<TFixture> : FiltersInheritanceQueryTestBase<TFixture>
+    where TFixture : TPCInheritanceQueryFixture, new()
+{
+    public TPCFiltersInheritanceQueryTestBase(TFixture fixture)
+        : base(fixture)
+    {
+    }
+}

test/EFCore.Relational.Specification.Tests/Query/TPCGearsOfWarQueryRelationalFixture.cs

@@ -0,0 +1,42 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using Microsoft.EntityFrameworkCore.TestModels.GearsOfWarModel;
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCGearsOfWarQueryRelationalFixture : GearsOfWarQueryFixtureBase
+{
+    protected override string StoreName { get; } = "TPCGearsOfWarQueryTest";
+
+    public new RelationalTestStore TestStore
+        => (RelationalTestStore)base.TestStore;
+
+    public TestSqlLoggerFactory TestSqlLoggerFactory
+        => (TestSqlLoggerFactory)ListLoggerFactory;
+
+    protected override bool ShouldLogCategory(string logCategory)
+        => logCategory == DbLoggerCategory.Query.Name;
+
+    public override DbContextOptionsBuilder AddOptions(DbContextOptionsBuilder builder)
+        => base.AddOptions(builder).ConfigureWarnings(
+            w =>
+                w.Log(RelationalEventId.ForeignKeyTpcPrincipalWarning));
+
+    protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext context)
+    {
+        base.OnModelCreating(modelBuilder, context);
+
+        modelBuilder.Entity<Gear>().UseTpcMappingStrategy();
+        modelBuilder.Entity<Faction>().UseTpcMappingStrategy();
+        modelBuilder.Entity<LocustLeader>().UseTpcMappingStrategy();
+
+        modelBuilder.Entity<Gear>().ToTable("Gears");
+        modelBuilder.Entity<Officer>().ToTable("Officers");
+
+        modelBuilder.Entity<LocustHorde>().ToTable("LocustHordes");
+
+        modelBuilder.Entity<LocustLeader>().ToTable("LocustLeaders");
+        modelBuilder.Entity<LocustCommander>().ToTable("LocustCommanders");
+    }
+}

test/EFCore.Relational.Specification.Tests/Query/TPCGearsOfWarQueryRelationalTestBase.cs

@@ -0,0 +1,16 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCGearsOfWarQueryRelationalTestBase<TFixture> : GearsOfWarQueryRelationalTestBase<TFixture>
+    where TFixture : TPCGearsOfWarQueryRelationalFixture, new()
+{
+    protected TPCGearsOfWarQueryRelationalTestBase(TFixture fixture)
+        : base(fixture)
+    {
+    }
+
+    public override Task Project_discriminator_columns(bool async)
+        => AssertUnableToTranslateEFProperty(() => base.Project_discriminator_columns(async));
+}

test/EFCore.Relational.Specification.Tests/Query/TPCInheritanceQueryFixture.cs

@@ -0,0 +1,57 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using Microsoft.EntityFrameworkCore.TestModels.InheritanceModel;
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCInheritanceQueryFixture : InheritanceQueryFixtureBase
+{
+    protected override string StoreName
+        => "TPCInheritanceTest";
+
+    public TestSqlLoggerFactory TestSqlLoggerFactory
+        => (TestSqlLoggerFactory)ListLoggerFactory;
+
+    protected override bool HasDiscriminator
+        => false;
+
+    protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext context)
+    {
+        base.OnModelCreating(modelBuilder, context);
+
+        // Configure TPT for hierarchies
+        modelBuilder.Entity<Plant>().UseTpcMappingStrategy();
+        modelBuilder.Entity<Animal>().UseTpcMappingStrategy();
+        modelBuilder.Entity<Drink>().UseTpcMappingStrategy();
+
+        modelBuilder.Entity<Flower>().ToTable("Flowers");
+        modelBuilder.Entity<Rose>().ToTable("Roses");
+        modelBuilder.Entity<Daisy>().ToTable("Daisies");
+        modelBuilder.Entity<Country>().Property(e => e.Id).ValueGeneratedNever();
+
+        modelBuilder.Entity<Bird>().ToTable("Birds");
+        modelBuilder.Entity<Eagle>().ToTable("Eagle");
+        modelBuilder.Entity<Kiwi>().ToTable("Kiwi");
+        modelBuilder.Entity<Animal>().Property(e => e.Species).HasMaxLength(100);
+        modelBuilder.Entity<Eagle>().HasMany(e => e.Prey).WithOne().HasForeignKey(e => e.EagleId).IsRequired(false);
+
+        modelBuilder.Entity<Drink>().ToTable("Drinks");
+        modelBuilder.Entity<Coke>().ToTable("Coke");
+        modelBuilder.Entity<Lilt>().ToTable("Lilt");
+        modelBuilder.Entity<Tea>().ToTable("Tea");
+
+        modelBuilder.Entity<Coke>().Property(e => e.Carbonation).HasColumnName("CokeCO2");
+        modelBuilder.Entity<Coke>().Property(e => e.SugarGrams).HasColumnName("SugarGrams");
+        modelBuilder.Entity<Coke>().Property(e => e.CaffeineGrams).HasColumnName("CaffeineGrams");
+        modelBuilder.Entity<Lilt>().Property(e => e.Carbonation).HasColumnName("LiltCO2");
+        modelBuilder.Entity<Lilt>().Property(e => e.SugarGrams).HasColumnName("SugarGrams");
+        modelBuilder.Entity<Tea>().Property(e => e.CaffeineGrams).HasColumnName("CaffeineGrams");
+
+        // Keyless entities are mapped to TPH so ignoring them
+        modelBuilder.Ignore<AnimalQuery>();
+        modelBuilder.Ignore<BirdQuery>();
+        modelBuilder.Ignore<KiwiQuery>();
+        modelBuilder.Ignore<EagleQuery>();
+    }
+}

test/EFCore.Relational.Specification.Tests/Query/TPCInheritanceQueryTestBase.cs

@@ -0,0 +1,55 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+// ReSharper disable InconsistentNaming
+
+using Microsoft.EntityFrameworkCore.TestModels.InheritanceModel;
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCInheritanceQueryTestBase<TFixture> : InheritanceQueryTestBase<TFixture>
+    where TFixture : TPCInheritanceQueryFixture, new()
+{
+    public TPCInheritanceQueryTestBase(TFixture fixture)
+        : base(fixture)
+    {
+    }
+
+    // Keyless entities does not have TPC
+    public override Task Can_query_all_animal_views(bool async)
+        => Task.CompletedTask;
+
+    // TPC does not have discriminator
+    public override Task Discriminator_used_when_projection_over_derived_type(bool async)
+        => Task.CompletedTask;
+
+    // TPC does not have discriminator
+    public override Task Discriminator_used_when_projection_over_derived_type2(bool async)
+        => Task.CompletedTask;
+
+    // TPC does not have discriminator
+    public override Task Discriminator_used_when_projection_over_of_type(bool async)
+        => Task.CompletedTask;
+
+    // TPC does not have discriminator
+    public override Task Discriminator_with_cast_in_shadow_property(bool async)
+        => Task.CompletedTask;
+
+    [ConditionalFact]
+    public virtual void Using_from_sql_throws()
+    {
+        using var context = CreateContext();
+
+        var message = Assert.Throws<InvalidOperationException>(() => context.Set<Bird>().FromSqlRaw("Select * from Birds")).Message;
+
+        Assert.Equal(RelationalStrings.MethodOnNonTphRootNotSupported("FromSqlRaw", typeof(Bird).Name), message);
+
+        message = Assert.Throws<InvalidOperationException>(() => context.Set<Bird>().FromSqlInterpolated($"Select * from Birds"))
+            .Message;
+
+        Assert.Equal(RelationalStrings.MethodOnNonTphRootNotSupported("FromSqlInterpolated", typeof(Bird).Name), message);
+    }
+
+    protected override void UseTransaction(DatabaseFacade facade, IDbContextTransaction transaction)
+        => facade.UseTransaction(transaction.GetDbTransaction());
+}

test/EFCore.Relational.Specification.Tests/Query/TPCManyToManyNoTrackingQueryRelationalTestBase.cs

@@ -0,0 +1,13 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCManyToManyNoTrackingQueryRelationalTestBase<TFixture> : ManyToManyNoTrackingQueryRelationalTestBase<TFixture>
+    where TFixture : TPCManyToManyQueryRelationalFixture, new()
+{
+    protected TPCManyToManyNoTrackingQueryRelationalTestBase(TFixture fixture)
+        : base(fixture)
+    {
+    }
+}

test/EFCore.Relational.Specification.Tests/Query/TPCManyToManyQueryRelationalFixture.cs

@@ -0,0 +1,27 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using Microsoft.EntityFrameworkCore.TestModels.ManyToManyModel;
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCManyToManyQueryRelationalFixture : ManyToManyQueryRelationalFixture
+{
+    protected override string StoreName { get; } = "TPCManyToManyQueryTest";
+
+    public override DbContextOptionsBuilder AddOptions(DbContextOptionsBuilder builder)
+        => base.AddOptions(builder).ConfigureWarnings(
+            w =>
+                w.Log(RelationalEventId.ForeignKeyTpcPrincipalWarning));
+
+    protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext context)
+    {
+        base.OnModelCreating(modelBuilder, context);
+
+        modelBuilder.Entity<EntityRoot>().UseTpcMappingStrategy();
+
+        modelBuilder.Entity<EntityRoot>().ToTable("Roots");
+        modelBuilder.Entity<EntityBranch>().ToTable("Branches");
+        modelBuilder.Entity<EntityLeaf>().ToTable("Leaves");
+    }
+}

test/EFCore.Relational.Specification.Tests/Query/TPCManyToManyQueryRelationalTestBase.cs

@@ -0,0 +1,13 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCManyToManyQueryRelationalTestBase<TFixture> : ManyToManyQueryRelationalTestBase<TFixture>
+    where TFixture : TPCManyToManyQueryRelationalFixture, new()
+{
+    protected TPCManyToManyQueryRelationalTestBase(TFixture fixture)
+        : base(fixture)
+    {
+    }
+}

test/EFCore.Relational.Specification.Tests/Query/TPCRelationshipsQueryRelationalFixture.cs

@@ -0,0 +1,39 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using Microsoft.EntityFrameworkCore.TestModels.InheritanceRelationshipsModel;
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCRelationshipsQueryRelationalFixture : InheritanceRelationshipsQueryRelationalFixture
+{
+    protected override string StoreName { get; } = "TPCRelationships";
+
+    public override DbContextOptionsBuilder AddOptions(DbContextOptionsBuilder builder)
+        => base.AddOptions(builder).ConfigureWarnings(
+            w =>
+                w.Log(RelationalEventId.ForeignKeyTpcPrincipalWarning));
+
+    protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext context)
+    {
+        base.OnModelCreating(modelBuilder, context);
+
+        modelBuilder.Entity<BaseInheritanceRelationshipEntity>().UseTpcMappingStrategy();
+        modelBuilder.Entity<BaseReferenceOnBase>().UseTpcMappingStrategy();
+        modelBuilder.Entity<BaseCollectionOnBase>().UseTpcMappingStrategy();
+        modelBuilder.Entity<BaseReferenceOnDerived>().UseTpcMappingStrategy();
+        modelBuilder.Entity<BaseCollectionOnDerived>().UseTpcMappingStrategy();
+        modelBuilder.Entity<NestedReferenceBase>().UseTpcMappingStrategy();
+        modelBuilder.Entity<NestedCollectionBase>().UseTpcMappingStrategy();
+
+        modelBuilder.Entity<DerivedInheritanceRelationshipEntity>().ToTable("DerivedEntities");
+
+        modelBuilder.Entity<DerivedReferenceOnBase>().ToTable("DerivedReferencesOnBase");
+        modelBuilder.Entity<DerivedCollectionOnBase>().ToTable("DerivedCollectionsOnBase");
+        modelBuilder.Entity<DerivedReferenceOnDerived>().ToTable("DerivedReferencesOnDerived");
+        modelBuilder.Entity<DerivedCollectionOnDerived>().ToTable("DerivedCollectionsOnDerived");
+
+        modelBuilder.Entity<NestedReferenceDerived>().ToTable("NestedReferencesDerived");
+        modelBuilder.Entity<NestedCollectionDerived>().ToTable("NestedCollectionsDerived");
+    }
+}

test/EFCore.Relational.Specification.Tests/Query/TPCRelationshipsQueryTestBase.cs

@@ -0,0 +1,15 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+// ReSharper disable InconsistentNaming
+
+namespace Microsoft.EntityFrameworkCore.Query;
+
+public abstract class TPCRelationshipsQueryTestBase<TFixture> : InheritanceRelationshipsQueryRelationalTestBase<TFixture>
+    where TFixture : TPCRelationshipsQueryRelationalFixture, new()
+{
+    protected TPCRelationshipsQueryTestBase(TFixture fixture)
+        : base(fixture)
+    {
+    }
+}

test/EFCore.Relational.Specification.Tests/TestUtilities/TestSqlLoggerFactory.cs

@@ -287,7 +287,7 @@ void RewriteSourceWithNewBaseline(string fileName, int lineNumber)
                         indentBuilder.Append("    ");
                         var indent = indentBuilder.ToString();
                         var newBaseLine = $@"AssertSql(
-{indent}{string.Join(",\n" + indent + "//\n" + indent, SqlStatements.Select(sql => "@\"" + sql.Replace("\"", "\"\"") + "\""))})";
+{indent}{string.Join("," + Environment.NewLine + indent + "//" + Environment.NewLine + indent, SqlStatements.Select(sql => "@\"" + sql.Replace("\"", "\"\"") + "\""))})";
                         var numNewlinesInRewritten = newBaseLine.Count(c => c is '\n' or '\r');
 
                         writer.Write(newBaseLine);

test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs

@@ -5257,7 +5257,7 @@ public virtual Task Nav_rewrite_Distinct_with_convert()
             () =>
             {
                 using var ctx = CreateContext();
-                _ = ctx.Factions.Include(f => ((LocustHorde)f).Commander)
+                _ = ctx.Set<Faction>().Include(f => ((LocustHorde)f).Commander)
                     .Where(f => f.Capital.Name != "Foo").Select(f => (LocustHorde)f)
                     .Distinct().Where(lh => lh.Commander.Name != "Bar").ToList();
                 return Task.CompletedTask;
@@ -5270,7 +5270,7 @@ public virtual Task Nav_rewrite_Distinct_with_convert_anonymous()
             () =>
             {
                 using var ctx = CreateContext();
-                _ = ctx.Factions.Include(f => ((LocustHorde)f).Commander)
+                _ = ctx.Set<Faction>().Include(f => ((LocustHorde)f).Commander)
                     .Where(f => f.Capital.Name != "Foo").Select(f => new { horde = (LocustHorde)f })
                     .Distinct().Where(lh => lh.horde.Commander.Name != "Bar").ToList();
                 return Task.CompletedTask;

test/EFCore.Specification.Tests/TestModels/GearsOfWarModel/GearsOfWarContext.cs

@@ -17,7 +17,6 @@ public GearsOfWarContext(DbContextOptions options)
     public DbSet<City> Cities { get; set; }
     public DbSet<Mission> Missions { get; set; }
     public DbSet<SquadMission> SquadMissions { get; set; }
-    public DbSet<Faction> Factions { get; set; }
     public DbSet<LocustLeader> LocustLeaders { get; set; }
     public DbSet<LocustHighCommand> LocustHighCommands { get; set; }
 
@@ -45,7 +44,7 @@ public static void Seed(GearsOfWarContext context)
         context.Tags.AddRange(tags);
         context.Gears.AddRange(gears);
         context.LocustLeaders.AddRange(locustLeaders);
-        context.Factions.AddRange(factions);
+        context.Set<Faction>().AddRange(factions);
         context.LocustHighCommands.AddRange(locustHighCommands);
         context.SaveChanges();
 

test/EFCore.Specification.Tests/TestModels/InheritanceModel/InheritanceContext.cs

@@ -10,11 +10,9 @@ public InheritanceContext(DbContextOptions options)
     {
     }
 
-    public DbSet<Animal> Animals { get; set; }
     public DbSet<AnimalQuery> AnimalQueries { get; set; }
     public DbSet<Country> Countries { get; set; }
     public DbSet<Drink> Drinks { get; set; }
-    public DbSet<Plant> Plants { get; set; }
 
     public static void Seed(InheritanceContext context)
     {
@@ -25,10 +23,10 @@ public static void Seed(InheritanceContext context)
 
         InheritanceData.WireUp(animals, countries);
 
-        context.Animals.AddRange(animals);
+        context.Set<Animal>().AddRange(animals);
         context.Countries.AddRange(countries);
         context.Drinks.AddRange(drinks);
-        context.Plants.AddRange(plants);
+        context.Set<Plant>().AddRange(plants);
 
         context.SaveChanges();
     }