Update the foreign key builder after IsRequired()

Fixes #26611
dotnet · Nov 17, 2021 · f5d7895 · f5d7895
1 parent 6fc3e17
commit f5d7895
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/src/EFCore/Metadata/Internal/InternalForeignKeyBuilder.cs b/src/EFCore/Metadata/Internal/InternalForeignKeyBuilder.cs
@@ -973,7 +973,13 @@ private static bool IsCompatible(
                 Metadata.DeclaringEntityType.Model.ScopedModelDependencies?.Logger.AmbiguousEndRequiredWarning(Metadata);
             }
 
-            Metadata.SetIsRequired(required, configurationSource);
+            IConventionForeignKey? foreignKey = Metadata;
+            var result = Metadata.DeclaringEntityType.Model.ConventionDispatcher.Track(
+                () => Metadata.SetIsRequired(required, configurationSource), ref foreignKey);
+            if (foreignKey != null)
+            {
+                return ((ForeignKey)foreignKey).Builder;
+            }
 
             return this;
         }

diff --git a/test/EFCore.Tests/ModelBuilding/ManyToOneTestBase.cs b/test/EFCore.Tests/ModelBuilding/ManyToOneTestBase.cs
@@ -1942,14 +1942,17 @@ public virtual void Creates_shadow_FK_property_with_non_shadow_PK()
                     {
                         b.HasMany<Beta>()
                             .WithOne(e => e.FirstNav)
-                            .HasForeignKey("ShadowId");
+                            .HasForeignKey("ShadowId")
+                            .IsRequired()
+                            .HasAnnotation("Test", "foo");
                     });
 
-                modelBuilder.FinalizeModel();
+                var model = modelBuilder.FinalizeModel();
 
-                Assert.Equal(
-                    "ShadowId",
-                    modelBuilder.Model.FindEntityType(typeof(Beta)).FindNavigation("FirstNav").ForeignKey.Properties.Single().Name);
+                var fk = model.FindEntityType(typeof(Beta)).FindNavigation("FirstNav").ForeignKey;
+                Assert.Equal("ShadowId", fk.Properties.Single().Name);
+                Assert.True(fk.IsRequired);
+                Assert.Equal("foo", fk["Test"]);
             }
 
             [ConditionalFact]