Add a generic overload of ConventionSetBuilder.Remove

Fixes #29476
dotnet · Nov 8, 2022 · fa33742 · fa33742
1 parent a23cff5
commit fa33742
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/EFCore/Metadata/Builders/ConventionSetBuilder.cs b/src/EFCore/Metadata/Builders/ConventionSetBuilder.cs
@@ -65,6 +65,14 @@ public virtual void Add(Func<IServiceProvider, IConvention> conventionFactory)
     public virtual void Remove(Type conventionType)
         => _conventionSet.Remove(conventionType);
 
+    /// <summary>
+    ///     Remove the convention of the given type.
+    /// </summary>
+    /// <typeparam name="TImplementaion">The type of convention to remove</typeparam>
+    public virtual void Remove<TImplementaion>()
+        where TImplementaion : IConvention
+        => Remove(typeof(TImplementaion));
+
     #region Hidden System.Object members
 
     /// <summary>

diff --git a/test/EFCore.Tests/ModelBuilding/NonRelationshipTestBase.cs b/test/EFCore.Tests/ModelBuilding/NonRelationshipTestBase.cs
@@ -426,6 +426,21 @@ public virtual void Conventions_can_be_removed()
 
             var model = modelBuilder.FinalizeModel();
 
+            Assert.Null(model["foo"]);
+        }
+
+		[ConditionalFact]
+        public virtual void Conventions_can_be_removed_by_generic_method()
+		{
+            var modelBuilder = CreateModelBuilder(
+                c =>
+                {
+                    c.Conventions.Add(s => new TestConvention());
+                    c.Conventions.Remove<TestConvention>();
+                });
+
+            var model = modelBuilder.FinalizeModel();
+
             Assert.Null(model["foo"]);
         }