Review updates

dotnet · Jan 14, 2022 · ff3ade7 · ff3ade7
1 parent c9b2a87
commit ff3ade7
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 10 deletions.
diff --git a/test/EFCore.InMemory.FunctionalTests/Query/NorthwindMiscellaneousQueryInMemoryTest.cs b/test/EFCore.InMemory.FunctionalTests/Query/NorthwindMiscellaneousQueryInMemoryTest.cs
@@ -17,32 +17,32 @@ public NorthwindMiscellaneousQueryInMemoryTest(
     }
 
     public override Task Where_query_composition_entity_equality_one_element_Single(bool async)
-        // Sequence contains no elements. Issue #?????.
+        // Sequence contains no elements.
         => Assert.ThrowsAsync<InvalidOperationException>(
             () => base.Where_query_composition_entity_equality_one_element_Single(async));
 
     public override Task Where_query_composition_entity_equality_one_element_First(bool async)
-        // Sequence contains no elements. Issue #?????.
+        // Sequence contains no elements.
         => Assert.ThrowsAsync<InvalidOperationException>(
             () => base.Where_query_composition_entity_equality_one_element_First(async));
 
     public override Task Where_query_composition_entity_equality_no_elements_Single(bool async)
-        // Sequence contains no elements. Issue #?????.
+        // Sequence contains no elements.
         => Assert.ThrowsAsync<InvalidOperationException>(
             () => base.Where_query_composition_entity_equality_no_elements_Single(async));
 
     public override Task Where_query_composition_entity_equality_no_elements_First(bool async)
-        // Sequence contains no elements. Issue #?????.
+        // Sequence contains no elements.
         => Assert.ThrowsAsync<InvalidOperationException>(
             () => base.Where_query_composition_entity_equality_no_elements_First(async));
 
     public override Task Where_query_composition_entity_equality_multiple_elements_SingleOrDefault(bool async)
-        // Sequence contains more than one element. Issue #?????.
+        // Sequence contains more than one element.
         => Assert.ThrowsAsync<InvalidOperationException>(
             () => base.Where_query_composition_entity_equality_multiple_elements_SingleOrDefault(async));
 
     public override Task Where_query_composition_entity_equality_multiple_elements_Single(bool async)
-        // Sequence contains more than one element. Issue #?????.
+        // Sequence contains more than one element.
         => Assert.ThrowsAsync<InvalidOperationException>(
             () => base.Where_query_composition_entity_equality_multiple_elements_Single(async));
 

diff --git a/test/EFCore.SqlServer.FunctionalTests/Query/NorthwindFunctionsQuerySqlServerTest.cs b/test/EFCore.SqlServer.FunctionalTests/Query/NorthwindFunctionsQuerySqlServerTest.cs
@@ -946,16 +946,16 @@ FROM [Order Details] AS [o]
 
     public override async Task Where_math_min(bool async)
     {
-        // Translate Math.Min. Issue #?????.
-        await AssertTranslationFailed(() => base.TrimStart_with_char_array_argument_in_predicate(async));
+        // Translate Math.Min.
+        await AssertTranslationFailed(() => base.Where_math_min(async));
 
         AssertSql();
     }
 
     public override async Task Where_math_max(bool async)
     {
-        // Translate Math.Max. Issue #?????.
-        await AssertTranslationFailed(() => base.TrimStart_with_char_array_argument_in_predicate(async));
+        // Translate Math.Max.
+        await AssertTranslationFailed(() => base.Where_math_max(async));
 
         AssertSql();
     }

diff --git a/test/EFCore.Sqlite.FunctionalTests/Query/NorthwindGroupByQuerySqliteTest.cs b/test/EFCore.Sqlite.FunctionalTests/Query/NorthwindGroupByQuerySqliteTest.cs
@@ -43,6 +43,13 @@ public override Task Select_nested_collection_with_groupby(bool async)
     public override Task Complex_query_with_group_by_in_subquery5(bool async)
         => AssertApplyNotSupported(() => base.Complex_query_with_group_by_in_subquery5(async));
 
+    public override Task GroupBy_aggregate_from_multiple_query_in_same_projection(bool async)
+        => AssertApplyNotSupported(() => base.GroupBy_aggregate_from_multiple_query_in_same_projection(async));
+
+    public override Task GroupBy_aggregate_from_multiple_query_in_same_projection_3(bool async)
+        => Assert.ThrowsAsync<SqliteException>(
+            () => base.GroupBy_aggregate_from_multiple_query_in_same_projection_3(async));
+
     public override async Task Odata_groupby_empty_key(bool async)
         => Assert.Equal(
             SqliteStrings.AggregateOperationNotSupported("Sum", "decimal"),