Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try and remove SqlServerOptions #11660

Closed
anpete opened this issue Apr 12, 2018 · 0 comments · Fixed by #18987
Closed

Try and remove SqlServerOptions #11660

anpete opened this issue Apr 12, 2018 · 0 comments · Fixed by #18987
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
5.0.0

Comments

@anpete
Copy link
Contributor

anpete commented Apr 12, 2018

RowNumberPaging may not need to be a singleton option given that it is already a component of the SQL Server compiled query cache key.
@ajcvickers ajcvickers added this to the Backlog milestone Apr 13, 2018
@smitpatel smitpatel self-assigned this Nov 19, 2019
smitpatel added a commit that referenced this issue Nov 19, 2019
@smitpatel
Remove SqlServerOptions
b7d9cdf 
Resolves #11660
@smitpatel smitpatel added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup and removed type-enhancement labels Nov 19, 2019
@smitpatel smitpatel modified the milestones: Backlog, 5.0.0 Nov 19, 2019
@smitpatel smitpatel mentioned this issue Nov 19, 2019
Merged
smitpatel added a commit that referenced this issue Nov 23, 2019
@smitpatel
Remove SqlServerOptions
7a71eb0 
Resolves #11660
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Remove SqlServerOptions dotnet/efcore
3 participants
@anpete @ajcvickers @smitpatel