Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LogValueConversionSqlLiteralWarning #12085

Closed
ajcvickers opened this issue May 21, 2018 · 7 comments
Closed

Remove LogValueConversionSqlLiteralWarning #12085

ajcvickers opened this issue May 21, 2018 · 7 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@ajcvickers
Copy link
Member

And add a fwlink to the message.

@ajcvickers
Copy link
Member Author

@divega to create the forward link.

@ajcvickers ajcvickers added this to the 2.2.0 milestone May 21, 2018
@ajcvickers
Copy link
Member Author

See also #12045 which would be needed to handle all cases.

@divega
Copy link
Contributor

divega commented May 22, 2018

Created https://go.microsoft.com/fwlink/?linkid=874557, currently pointing to https://docs.microsoft.com/ef/core/modeling/value-conversions#limitations. But this section should be expanded with more useful information. I will create a docs issue for that.

@ajcvickers
Copy link
Member Author

Moving this to 3.0 to consider after query 3.0 work. Examples of things we might warn for:

  • Any SQL translation that makes use of a value-converted property, since the translation may not work with the actual database type.
  • Consider not warning if it is known the translation is safe--e.g. for quality,

@smitpatel
Copy link
Member

Blocked on #13192

@smitpatel
Copy link
Member

Discussed with @ajcvickers about this,
We wanted to warn whenever SQL literals/parameters generated using ValueConverters, but with #13192, it would be mostly correct use. It is highly likely that if we make error, it would cause invalid SQL. With that the warning provides little value. There could be some cases where it would generate valid but incorrect SQL, but if we are smart enough to identify such case, we can just fix it.

Re-purposing this issue to remove the warning.

@smitpatel smitpatel changed the title Make sure LogValueConversionSqlLiteralWarning covers all cases Remove LogValueConversionSqlLiteralWarning Jan 25, 2019
@smitpatel
Copy link
Member

The warning has been removed.

@smitpatel smitpatel modified the milestones: 3.0.0, 3.0.0-preview6 Jun 5, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants