Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate deadlock in AsyncSimpleQueryTestBase tests using pooling #12138

Closed
AndriySvyryd opened this issue May 24, 2018 · 4 comments
Closed

Investigate deadlock in AsyncSimpleQueryTestBase tests using pooling #12138

AndriySvyryd opened this issue May 24, 2018 · 4 comments
Assignees
@smitpatel
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-2.2 punted-for-3.0 type-bug
Milestone
3.0.0

Comments

@AndriySvyryd
Copy link
Member

The tests Throws_on_concurrent_query_list and Throws_on_concurrent_query_first cause deadlocks in other tests.
@AndriySvyryd
Copy link
Member Author

AndriySvyryd commented May 24, 2018 •
edited
Loading

Also the async tests in ConcurrencyDetectorTestBase when run against a relational provider, and SqlExecutorTestBase.Throws_on_concurrent_command_async

@ajcvickers ajcvickers added this to the 2.2.0 milestone May 25, 2018
@ajcvickers ajcvickers modified the milestones: 2.2.0-preview2, 2.2.0 Sep 11, 2018
@ajcvickers ajcvickers modified the milestones: 2.2.0, 3.0.0 Oct 3, 2018
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog May 10, 2019
@ajcvickers
Copy link
Member

Closing as this is no longer relevant with the latest query changes.

@ajcvickers ajcvickers removed this from the Backlog milestone May 11, 2019
@smitpatel smitpatel reopened this Aug 7, 2019
@smitpatel smitpatel self-assigned this Aug 7, 2019
@smitpatel
Copy link
Contributor

There is still deadlock in ConcurrencyDetectorTestBase

@smitpatel
Copy link
Contributor

Found the cause: re-entrant exception makes ConcurrencyDetector unusable and in pooling scenario, it would cause deadlock.

@smitpatel smitpatel mentioned this issue Aug 7, 2019
Closed
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 7, 2019
@smitpatel smitpatel added this to the 3.0.0 milestone Aug 7, 2019
smitpatel added a commit that referenced this issue Aug 7, 2019
@smitpatel
Query: Remove serialization of async query code
ee12601 
This was causing deadlock issue in product because after concurrency exception the context is unusuable and in pooling scenario it caused forever wait in async queries

Resolves #10914
Resolves #12138
@smitpatel smitpatel mentioned this issue Aug 7, 2019
Merged
smitpatel added a commit that referenced this issue Aug 8, 2019
@smitpatel
Query: Remove serialization of async query code
f3515b7 
This was causing deadlock issue in product because after concurrency exception the context is unusuable and in pooling scenario it caused forever wait in async queries

Resolves #10914
Resolves #12138
smitpatel added a commit that referenced this issue Aug 8, 2019
@smitpatel
Query: Remove serialization of async query code (#17016)
6c0e31e 
This was causing deadlock issue in product because after concurrency exception the context is unusuable and in pooling scenario it caused forever wait in async queries

Resolves #10914
Resolves #12138
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-2.2 punted-for-3.0 type-bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
4 participants
@ajcvickers @smitpatel @maumar @AndriySvyryd