Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load on tracked entity does not work if default Changetracking behaviour is no tracking #12209

Closed
smitpatel opened this issue Jun 1, 2018 · 0 comments
Closed

Load on tracked entity does not work if default Changetracking behaviour is no tracking #12209

smitpatel opened this issue Jun 1, 2018 · 0 comments
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
2.2.0

Comments

@smitpatel
Copy link
Contributor

From repro code of #10042 (comment)

When calling Load on collection/reference, we fetch related data from server but they are not assigned to the tracked entity if Changetracking behavior is no tracking.
@smitpatel smitpatel self-assigned this Jun 1, 2018
smitpatel added a commit that referenced this issue Jun 1, 2018
@smitpatel
Always do tracking query for Load
929a7e5 
Issue: If the ChangeTracking behaviour is set to NoTracking then calling Load on tracked entity won't track resuls of load query. Which results in load failing.
The fix is to issue AsTracking query so that results from load query are added to state manager and will be fixed up with tracked query

Currently calling Load on non tracked query does not work so this fix is safe in that regard.

Resolves #12209
@smitpatel smitpatel mentioned this issue Jun 1, 2018
Merged
@ajcvickers ajcvickers added this to the 2.2.0 milestone Jun 1, 2018
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 1, 2018
smitpatel added a commit that referenced this issue Jun 4, 2018
@smitpatel
Always do tracking query for Load
d4ef6da 
Issue: If the ChangeTracking behaviour is set to NoTracking then calling Load on tracked entity won't track resuls of load query. Which results in load failing.
The fix is to issue AsTracking query so that results from load query are added to state manager and will be fixed up with tracked query

Currently calling Load on non tracked query does not work so this fix is safe in that regard.

Resolves #12209
smitpatel added a commit that referenced this issue Jun 5, 2018
@smitpatel
Always do tracking query for Load
78216c2 
Issue: If the ChangeTracking behaviour is set to NoTracking then calling Load on tracked entity won't track resuls of load query. Which results in load failing.
The fix is to issue AsTracking query so that results from load query are added to state manager and will be fixed up with tracked query

Currently calling Load on non tracked query does not work so this fix is safe in that regard.

Resolves #12209
@ajcvickers ajcvickers modified the milestones: 2.2.0-preview2, 2.2.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel