Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove precision and scale type mapping fallback #12405

Closed
AndriySvyryd opened this issue Jun 19, 2018 · 2 comments · Fixed by #16485
Closed

Remove precision and scale type mapping fallback #12405

AndriySvyryd opened this issue Jun 19, 2018 · 2 comments · Fixed by #16485
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Milestone
3.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jun 19, 2018 •
edited
Loading

Also don't set Size, Precision or Scale in RelationalTypeMapping if the corresponding StoreTypePostfix is not set.
@AndriySvyryd AndriySvyryd added this to the 3.0.0 milestone Jun 19, 2018
@AndriySvyryd AndriySvyryd self-assigned this Jun 19, 2018
@AndriySvyryd AndriySvyryd mentioned this issue Jan 2, 2019
Merged
@ajcvickers ajcvickers mentioned this issue Feb 4, 2019
Closed
2 tasks
@roji
Copy link
Member

roji commented Feb 17, 2019

@AndriySvyryd can I poach? Am working in the area on #11896.

@AndriySvyryd
Copy link
Member Author

@roji Sure, let me know if you have any questions.

roji added a commit to roji/efcore that referenced this issue Feb 26, 2019
@roji
Remove 2.1 provider fallback behavior
d1423da 
* Removed precision/scale 2.1 fallback behavior
* Made RelationalTypeMapping.Clone() abstract

Part of dotnet#12405
@roji roji mentioned this issue Feb 26, 2019
Merged
roji added a commit to roji/efcore that referenced this issue Feb 26, 2019
@roji
Remove 2.1 provider fallback behavior
afcbc33 
* Removed precision/scale 2.1 fallback behavior
* Made RelationalTypeMapping.Clone() abstract

Part of dotnet#12405
roji added a commit that referenced this issue Feb 28, 2019
@roji
Remove 2.1 provider fallback behavior
c5167be 
* Removed precision/scale 2.1 fallback behavior
* Made RelationalTypeMapping.Clone() abstract

Part of #12405
@roji roji mentioned this issue Mar 16, 2019
Closed
@ajcvickers ajcvickers assigned ajcvickers and unassigned roji Jun 27, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 6, 2019
ajcvickers added a commit that referenced this issue Jul 6, 2019
@ajcvickers
Allow store type name shape to be customized
ff83f6d 
Fixes #12405
@ajcvickers ajcvickers mentioned this issue Jul 6, 2019
Merged
ajcvickers added a commit that referenced this issue Jul 7, 2019
@ajcvickers
Allow store type name shape to be customized
321a236 
Fixes #12405
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview8 Jul 29, 2019
@ajcvickers ajcvickers removed this from the 3.0.0-preview8 milestone Nov 11, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Allow store type name shape to be customized dotnet/efcore
3 participants
@ajcvickers @roji @AndriySvyryd